Date: Mon, 13 Jun 2005 21:02:07 +0100 From: Christoph Hellwig <hch@infradead.org> To: Julian Elischer <julian@elischer.org> Cc: Daniel Eischen <deischen@freebsd.org>, freebsd-hackers@freebsd.org, Scott Long <scottl@samsco.org>, Apache Xie <apachexm@hotmail.com> Subject: Re: contigmalloc() and mmap() Message-ID: <20050613200207.GA5823@infradead.org> In-Reply-To: <20050613195917.GA5710@infradead.org> References: <Pine.GSO.4.43.0506131332380.23852-100000@sea.ntplx.net> <42ADC762.6010801@elischer.org> <20050613181435.GA3096@infradead.org> <42ADD253.4020606@samsco.org> <20050613184551.GA3853@infradead.org> <42ADD6AC.3060505@samsco.org> <20050613190224.GA4308@infradead.org> <42ADE480.9040908@elischer.org> <20050613195917.GA5710@infradead.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 13, 2005 at 08:59:17PM +0100, Christoph Hellwig wrote: > disk drivers use a completely different set of entry points in Linux, > and don't have access to per-fd data even in the case they're opened > from userland. Character drivers to which this applies OTOH always > get a valid struct file, it's guranteed as part of the driver API. That beeing said I'd suggest to not pass down the whole file struct if you want to add this feature for freebsd but just some well-defined API to store data in them. Giving driver writers less rope to shoot themselves improves averange driver quality significantly. We'll probably move towards such an API in Linux aswell one day, but it's a lot of work once drivers have started to do all kinds of nasty things.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050613200207.GA5823>