Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 31 Aug 2005 11:41:08 +0200
From:      Stefan Walter <sw@gegenunendlich.de>
To:        Renato Botelho <garga@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org
Subject:   Re: cvs commit: ports/misc/vifm Makefile distinfo
Message-ID:  <20050831094108.GA854@kyuzo.dunkelkammer.void>
In-Reply-To: <20050830160305.GA71092@galle.com.br>
References:  <200508291016.j7TAGTfS035283@repoman.freebsd.org> <20050830150858.GA1137@kyuzo.dunkelkammer.void> <20050830160305.GA71092@galle.com.br>

next in thread | previous in thread | raw e-mail | index | archive | help

--k1lZvvs/B4yU6o8G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Renato Botelho, 30.08.05, 18:03h CEST:

> > The changes you made also added a new call of REINPLACE_CMD that wasn't=
 in
> > my patch. I (the maintainer) wasn't asked or notified about it at all, =
and
> > it doesn't even show up in the commit log. What's the purpose of the ad=
ded
> > call, and why wasn't I asked before it was committed?
>=20
> After apply your patch the port stops to build on FreeBSD-4.x, so, I
> made this change just to fix the build.
>=20
> Anyway, sorry about the mistake.

OK. Thanks for the fix, I couldn't test it on RELENG_4 and thus wasn't
aware of the problem. But please get some feedback before committing
changes to a port which has a maintainer, as that's the person people turn
to if something's wrong, especially after an update.

Regards,
Stefan

--k1lZvvs/B4yU6o8G
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iQGVAwUBQxV7NFaRERsSueCzAQJ9GAv+OkOKmSUGZvthlKI8RFtz1IIpXJWZoo0U
6AOfIjlVstjSIOe5vAc76wg1oxInfaSAG5hsnD6AQMdVqNqD0vYfALExy0BHTLup
bMW3vTGSReeGopylk9/tDiAmhECCEV8olpo3t+spoQ2cHNWCZHfiwI57XI149cGe
ru0NHOGGGUaoAQHLpUTPyDp2lDux0BRU85fn1ggESKjIDtuWJXDKjyAsQRFwHC6X
zVJmUdIbBiBEbdydpu7iVRPNXElS387NCBxx+UBRO1Ooy6lufyIz4iEaaw21FEC/
GvdUw8bJNUrB24MuE5AsmuQj552OuIAHpKilbADvJuKE3PcyufDg7RlCoUcG3eO1
8R9W1Rqiin/b1Md0CUqGtG8Lhy/TeQhy8gA91dpGfB57S3Ou9e8Is13DQoq2aUCB
z8vTmFI8r59xN3cjwfpJI1KQ3kon5/G4D2OcjOJANgi+nQbAifzLUvb64Z4nXm7d
XJ2sUu6eDg8T0Nm3BJZIQBfcY5N2LwXe
=U/TQ
-----END PGP SIGNATURE-----

--k1lZvvs/B4yU6o8G--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050831094108.GA854>