Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Mar 2007 17:26:54 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Paolo Pisati <piso@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 115371 for review
Message-ID:  <200703051726.54857.jhb@freebsd.org>
In-Reply-To: <200703052204.l25M4lnF061780@repoman.freebsd.org>
References:  <200703052204.l25M4lnF061780@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 05 March 2007 17:04, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=115371
> 
> Change 115371 by piso@piso_newluxor on 2007/03/05 22:04:19
> 
> 	Wrap at 80 ppbus_setup_intr().

You can remove the cast instead.  C doesn't require casts for void * pointers.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/ppbus/ppbconf.c#5 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/ppbus/ppbconf.c#5 (text+ko) 
====
> 
> @@ -421,7 +421,8 @@
>  {
>  	int error;
>  	struct ppb_data *ppb = DEVTOSOFTC(bus);
> -	struct ppb_device *ppbdev = (struct ppb_device *)device_get_ivars(child);
> +	struct ppb_device *ppbdev = 
> +	    (struct ppb_device *)device_get_ivars(child);
>  
>  	/* a device driver must own the bus to register an interrupt */
>  	if (ppb->ppb_owner != child)
> 

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200703051726.54857.jhb>