Date: Mon, 20 Aug 2007 13:37:50 +0300 From: Diomidis Spinellis <dds@aueb.gr> To: Jeff Roberson <jroberson@chesapeake.net> Cc: attilio@FreeBSD.ORG, jeff@FreeBSD.ORG, Robert Watson <rwatson@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: Crash in accounting code: encode_long(), due to bad rusage data? Message-ID: <46C96EFE.6070400@aueb.gr> In-Reply-To: <20070819164823.H568@10.0.0.1> References: <20070819214953.I1099@fledge.watson.org> <46C8C2E6.9030405@aueb.gr> <20070819164823.H568@10.0.0.1>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeff Roberson wrote: >> Robert Watson wrote: >>> I recently upgraded two servers from FreeBSD 6-STABLE to FreeBSD >>> 7-CURRENT in anticipation of the forthcoming release. Both of them >>> run with accounting enabled at all times. When a large pine session >>> was exiting on one of the two boxes, I ran into the following panic: >>> >>> panic: encode_long: -ve value -32749 [...] > What do you think about simply putting in a max value if we overflow? > We could then make a note about it in process accounting docs. We might > want to fix this in rusage as well. Encoding LONG_MAX and issuing a printf warning is I think a reasonable solution. I'll be away from a broadband connection until Friday, so if anybody else wants to commit this, go ahead. Otherwise I can do it over the coming weekend. Diomidis Spinellis - http://www.spinellis.gr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46C96EFE.6070400>