Date: Tue, 4 Dec 2007 09:55:41 -0800 From: "David O'Brien" <obrien@freebsd.org> To: Giorgos Keramidas <keramida@freebsd.org> Cc: FreeBSD Release Engineers <re@freebsd.org>, Alexander Kabaev <kan@freebsd.org>, youshi10@u.washington.edu, freebsd-current@freebsd.org, Bruce Evans <bde@freebsd.org> Subject: Re: [PATCH] gprof's broken in 7-CURRENT Message-ID: <20071204175541.GC47398@dragon.NUXI.org> In-Reply-To: <20071130013826.GA66484@kobe.laptop> References: <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071129233842.GA57951@ace.netcins.ceid.upatras.gr> <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071130013826.GA66484@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm not sure what the action item is. This looks OK to me - do you want me to commit it to HEAD right now so we can let it soak a little before discussing it with RE? -- David On Fri, Nov 30, 2007 at 03:38:27AM +0200, Giorgos Keramidas wrote: > Please pass this through the release engineering team, Bruce Evans > (who has the largest number of commits to the file), and our gcc > folks (David O'Brien, and Alexander Kabaev). > > If it is considered safe for RELENG_7 (what will become 7.0-RELEASE), > then it's probably a good idea to commit it. It looks `harmless' to me, > but it certainly won't harm to get a proper review from much more > experienced people (added to the Cc: list). > > It would be marvellous to have non-broken profiling in 7.0. > > - Giorgos > > On 2007-11-30 01:38, Nikos Ntarmos <ntarmos@ceid.upatras.gr> wrote: > > I couldn't wait for Garrett :) so I went on and tested your patch and > > gprof seems to work fine for me (at least for the executables I was > > interested in profiling anyway). This is i386 on a 7.0-BETA3 kernel and > > 7.0-BETA1 world. What are the chances for this to be committed in time > > for 7.0R? > > On 2007-11-29 20:24, Luoqi Chen <luoqi@freebsd.org> wrote: > > Garrett, would you like to try out my fix? It's actually quite simple, -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071204175541.GC47398>