Date: Mon, 07 Jul 2008 11:01:38 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/125350: [libfetch] [patch] src/lib/libfetch add support for deflate and gzip encoded http downloads Message-ID: <86abgut6dp.fsf@ds4.des.no> In-Reply-To: <200807070253.m672re4a057604@freefall.freebsd.org> (linimon@freebsd.org's message of "Mon\, 7 Jul 2008 02\:53\:40 GMT") References: <200807070253.m672re4a057604@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I dislike the idea of nested funopen(); I would much prefer using a single code path for transfer and content encoding. openRandom(), httpDecodeRandom() are bad ideas and should not be implemented. Support for COMPRESS encoding is unnecessary. I am not aware of any HTTP server that implements it, nor of any HTTP server that does not support DEFLATE (except for those that do not support compression at all). The new code needs to conform to the style of the existing code, i.e. style(9). This includes changing function names and removing javadoc metadata. Adding new .c and .h files is unnecessary, the new code can go in common.[ch]. Cleaning up http.c is more trouble (and risk) than it's worth. If it works, don't fix it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86abgut6dp.fsf>