Date: Fri, 12 Feb 2010 22:38:27 +0100 (CET) From: Daniel Walter <d.walter@0x90.at> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-acpi@FreeBSD.org Subject: Re: Call for testers acpi_dell Message-ID: <alpine.BSF.2.00.1002122232380.5956@mini-beast.lan> In-Reply-To: <201002121541.29429.jkim@FreeBSD.org> References: <alpine.BSF.2.00.1002121840460.1675@mini-beast> <201002121448.20071.jkim@FreeBSD.org> <alpine.BSF.2.00.1002122110190.1413@mini-beast.lan> <201002121541.29429.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---496892480-1044077609-1266010709=:5956 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Fri, 12 Feb 2010, Jung-uk Kim wrote: > On Friday 12 February 2010 03:12 pm, Daniel Walter wrote: >> On Fri, 12 Feb 2010, Jung-uk Kim wrote: >>> On Friday 12 February 2010 02:37 pm, Daniel Walter wrote: >>>> On Fri, 12 Feb 2010, Jung-uk Kim wrote: >>>>> On Friday 12 February 2010 01:33 pm, Daniel Walter wrote: >>>>>> On Fri, 12 Feb 2010, Jung-uk Kim wrote: >>>>>>> On Friday 12 February 2010 12:48 pm, Daniel Walter wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I've written a small kernel driver to support Dell Mini 1011 >>>>>>>> (aka Dell Mini 10v) Brightness Controll Buttons. Since I do >>>>>>>> not have any other Dell Notebooks, I'd like you to test this >>>>>>>> module on other Dell Notebooks as well. >>>>>>>> >>>>>>>> This driver is in an early stage, but future releases will >>>>>>>> also support the rfkill switch and CRT switch. >>>>>>>> >>>>>>>> Currently following features are implemented: >>>>>>>> * Increase / Decrease Brightness >>>>>>>> * Change brightness if AC is connected / disconnected >>>>>>>> >>>>>>>> TODO: >>>>>>>> * Add CRT Support >>>>>>>> * Add Sysctl to define brightness levels for eco and ac >>>>>>>> powerprofile * Add Support for RF-Kill Switch >>>>>>>> >>>>>>>> Any suggestions are welcome >>>>>>> >>>>>>> I just quickly glanced at it but I failed see anything quite >>>>>>> specific to Dell laptops except for "TODO: Add support for >>>>>>> RF-Kill Switch". acpi_video(4) should be able to do what you >>>>>>> want. Am I missing something here? >>>>>>> >>>>>>> Jung-uk Kim >>>>>> >>>>>> hi, >>>>>> >>>>>> Yes it is possible to control the brightness using >>>>>> acpi_video(4) via sysctl but there is no support for the >>>>>> FN-Buttons. This module adds the support for those buttons. >>>>> >>>>> I see. However, my point is the probe function does not seem >>>>> specific to Dell laptops. In fact, you are just checking _BCL >>>>> transition, i.e., effectively it just makes a generic >>>>> acpi_video notify handler for brightness change. >>>>> >>>>> Jung-uk Kim >>>> >>>> Oh, I've completly overlooked this one. Sorry for that, I should >>>> replace the probing with a Dell specific probing instead. Do you >>>> have any suggestions to this one ? >>> >>> It totally depends on DSDT of your laptop model and you will have >>> to maintain the list of these ACPI handles, unfortunately. >>> Please see acpi_asus.c for example. >>> >>> If you are interested in generic acpi_video(4) enhancement, you >>> just need to extend acpi_video.c to get these notifications, >>> i.e., 0x86 and 0x87. FYI, acpi_video can only handle 0x80 and >>> 0x81 events ATM. Please read ACPI specification Appendix B. Video >>> Extensions, especially B.6 and B.7 are what you are looking for. >>> >>> Jung-uk Kim >> >> Hi I'll take a look at my DSDT again ... >> >> I've also will take a look at Appendix B of the current ACPI spec >> to see if 0x86 and 0x87 are OEM or part of the standard. If they >> are not completly out of spec I'll patch acpi_video(4) and send it >> again to the list. > > 0x86/0x87 is part of the spec. and it should be handled by acpi_video > IMHO. > > Jung-uk Kim hi, as you suggested I've written a patch for acpi_video(4) to support the 0x86 and 0x87 notifications. the support for 0x85, 0x88, 0x89 (also specified in ACPI Standard Appendix B7) is not yet implemented. Could anyone with a ACPI sending 0x86 and 0x87 test the patch ? thanks for the help and pointing my in the right direction. regards Daniel ---496892480-1044077609-1266010709=:5956 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=acpi_video.diff Content-Transfer-Encoding: BASE64 Content-ID: <alpine.BSF.2.00.1002122238260.5956@mini-beast.lan> Content-Description: Content-Disposition: attachment; filename=acpi_video.diff LS0tIC91c3Ivc3JjL3N5cy9kZXYvYWNwaWNhL2FjcGlfdmlkZW8uYwkyMDA5 LTEwLTI1IDAyOjEwOjI5LjAwMDAwMDAwMCArMDEwMA0KKysrIGFjcGlfdmlk ZW8uYwkyMDEwLTAyLTEyIDIyOjM3OjIyLjAwMDAwMDAwMCArMDEwMA0KQEAg LTIzLDcgKzIzLDcgQEANCiAgKiBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G DQogICogU1VDSCBEQU1BR0UuDQogICoNCi0gKgkkSWQ6IGFjcGlfdmlkLmMs diAxLjQgMjAwMy8xMC8xMyAxMDowNzozNiB0YWt1IEV4cCAkDQorICoJJElk OiBhY3BpX3ZpZGVvLmMgMyAyMDEwLTAyLTEyIDE2OjI0OjIwWiBzYWhuZSAk DQogICovDQogDQogI2luY2x1ZGUgPHN5cy9jZGVmcy5oPg0KQEAgLTg3LDYg Kzg3LDcgQEANCiBzdGF0aWMgaW50CWFjcGlfdmlkZW9fdm9fYnJpZ2h0X3N5 c2N0bChTWVNDVExfSEFORExFUl9BUkdTKTsNCiBzdGF0aWMgaW50CWFjcGlf dmlkZW9fdm9fcHJlc2V0c19zeXNjdGwoU1lTQ1RMX0hBTkRMRVJfQVJHUyk7 DQogc3RhdGljIGludAlhY3BpX3ZpZGVvX3ZvX2xldmVsc19zeXNjdGwoU1lT Q1RMX0hBTkRMRVJfQVJHUyk7DQorc3RhdGljIHZvaWQJYWNwaV92aWRlb192 b19ub3RpZnlfaGFuZGxlcihBQ1BJX0hBTkRMRSwgVUlOVDMyLCB2b2lkICop Ow0KIA0KIC8qIG9wZXJhdGlvbnMgKi8NCiBzdGF0aWMgdm9pZAl2aWRfc2V0 X3N3aXRjaF9wb2xpY3koQUNQSV9IQU5ETEUsIFVJTlQzMik7DQpAQCAtOTks OCArMTAwLDEwIEBADQogc3RhdGljIHZvaWQJdm9fc2V0X2RldmljZV9zdGF0 ZShBQ1BJX0hBTkRMRSwgVUlOVDMyKTsNCiANCiAvKiBldmVudHMgKi8NCi0j ZGVmaW5lIFZJRF9OT1RJRllfU1dJVENIRUQJMHg4MA0KLSNkZWZpbmUgVklE X05PVElGWV9SRVBST0JFCTB4ODENCisjZGVmaW5lIFZJRF9OT1RJRllfU1dJ VENIRUQJCTB4ODANCisjZGVmaW5lIFZJRF9OT1RJRllfUkVQUk9CRQkJMHg4 MQ0KKyNkZWZpbmUgVklEX05PVElGWV9CUklHSFRORVNTX1VQCTB4ODYNCisj ZGVmaW5lIFZJRF9OT1RJRllfQlJJR0hUTkVTU19ET1dOCTB4ODcNCiANCiAv KiBfRE9TIChFbmFibGUvRGlzYWJsZSBPdXRwdXQgU3dpdGNoaW5nKSBhcmd1 bWVudCBiaXRzICovDQogI2RlZmluZSBET1NfU1dJVENIX01BU0sJCTMNCkBA IC01NjYsNiArNTY5LDggQEANCiAJCQkvKiBYWFggLSBzZWUgYWJvdmUuICov DQogCQkJdm8tPnZvX2Vjb25vbXkgPSB2by0+dm9fbGV2ZWxzW0JDTF9FQ09O T01ZXTsNCiAJfQ0KKwlBY3BpSW5zdGFsbE5vdGlmeUhhbmRsZXIodm8tPmhh bmRsZSxBQ1BJX0RFVklDRV9OT1RJRlksDQorCQkJYWNwaV92aWRlb192b19u b3RpZnlfaGFuZGxlciwgdm8pOw0KIH0NCiANCiBzdGF0aWMgdm9pZA0KQEAg LTU3NCw2ICs1NzksOSBAQA0KIAlzdHJ1Y3QgYWNwaV92aWRlb19vdXRwdXRf cXVldWUgKnZvcWg7DQogDQogCUFDUElfU0VSSUFMX0FTU0VSVCh2aWRlbyk7 DQorCUFjcGlSZW1vdmVOb3RpZnlIYW5kbGVyKHZvLT5oYW5kbGUsIEFDUElf REVWSUNFX05PVElGWSwgDQorCQkJCWFjcGlfdmlkZW9fdm9fbm90aWZ5X2hh bmRsZXIpOw0KKw0KIAlpZiAodm8tPnZvX3N5c2N0bF90cmVlICE9IE5VTEwp IHsNCiAJCXZvLT52b19zeXNjdGxfdHJlZSA9IE5VTEw7DQogCQlzeXNjdGxf Y3R4X2ZyZWUoJnZvLT52b19zeXNjdGxfY3R4KTsNCkBAIC05MzksMyArOTQ3 LDU2IEBADQogCQlwcmludGYoImNhbid0IGV2YWx1YXRlICVzLl9EU1MgLSAl c1xuIiwNCiAJCSAgICAgICBhY3BpX25hbWUoaGFuZGxlKSwgQWNwaUZvcm1h dEV4Y2VwdGlvbihzdGF0dXMpKTsNCiB9DQorDQorc3RhdGljIHZvaWQNCith Y3BpX3ZpZGVvX3ZvX25vdGlmeV9oYW5kbGVyKEFDUElfSEFORExFIGhhbmRs ZSwgVUlOVDMyIG5vdGlmeSwgdm9pZCAqY29udGV4dCkNCit7DQorCXN0cnVj dCBhY3BpX3ZpZGVvX291dHB1dCAqdm87DQorCWludCBicmlnaHRuZXNzOw0K KwlpbnQgaSA9IDA7DQorCXZvID0gY29udGV4dDsNCisJc3dpdGNoKG5vdGlm eSkgewkNCisJY2FzZSBWSURfTk9USUZZX0JSSUdIVE5FU1NfVVA6DQorCQlB Q1BJX1NFUklBTF9CRUdJTih2aWRlbyk7DQorCQlpZiAodm8tPnZvX2xldmVs cyAhPSBOVUxMKSB7DQorCQkJYnJpZ2h0bmVzcyA9IHZvLT52b19icmlnaHRu ZXNzOw0KKwkJCWlmIChicmlnaHRuZXNzID09IC0xKSB7DQorCQkJCWJyaWdo dG5lc3MgPSB2by0+dm9fZnVsbHBvd2VyOw0KKwkJCX0NCisJCQ0KKwkJCWlm IChicmlnaHRuZXNzICE9IHZvLT52b19mdWxscG93ZXIpIHsNCisJCQkJZm9y IChpID0gMjsgaSA8IHZvLT52b19udW1sZXZlbHM7IGkrKykNCisJCQkJCWlm ICh2by0+dm9fbGV2ZWxzW2ldID09IGJyaWdodG5lc3MpDQorCQkJCQkJYnJl YWs7DQorCQkJfQ0KKwkJCWlmIChpICE9IHZvLT52b19udW1sZXZlbHMgLSAx KSB7DQorCQkJCWJyaWdodG5lc3MgPSB2by0+dm9fbGV2ZWxzW2krMV07DQor CQkJCXZvX3NldF9icmlnaHRuZXNzKHZvLT5oYW5kbGUsIGJyaWdodG5lc3Mp Ow0KKwkJCQl2by0+dm9fYnJpZ2h0bmVzcyA9IGJyaWdodG5lc3M7DQorCQkJ fQ0KKwkJfQ0KKwkJQUNQSV9TRVJJQUxfRU5EKHZpZGVvKTsNCisJCWJyZWFr Ow0KKwljYXNlIFZJRF9OT1RJRllfQlJJR0hUTkVTU19ET1dOOg0KKwkJQUNQ SV9TRVJJQUxfQkVHSU4odmlkZW8pOw0KKwkJaWYgKHZvLT52b19sZXZlbHMg IT0gTlVMTCkgew0KKwkJCWJyaWdodG5lc3MgPSB2by0+dm9fYnJpZ2h0bmVz czsNCisJCQlpZiAoYnJpZ2h0bmVzcyA9PSAtMSkgew0KKwkJCQlicmlnaHRu ZXNzID0gdm8tPnZvX2Z1bGxwb3dlcjsNCisJCQl9DQorCQkNCisJCQlmb3Ig KGkgPSAyOyBpIDwgdm8tPnZvX251bWxldmVsczsgaSsrKQ0KKwkJCQlpZiAo dm8tPnZvX2xldmVsc1tpXSA9PSBicmlnaHRuZXNzKQ0KKwkJCQkJYnJlYWs7 DQorCQkJaWYgKGkgPiAyKSB7DQorCQkJCWJyaWdodG5lc3MgPSB2by0+dm9f bGV2ZWxzW2ktMV07DQorCQkJCXZvX3NldF9icmlnaHRuZXNzKHZvLT5oYW5k bGUsIGJyaWdodG5lc3MpOw0KKwkJCQl2by0+dm9fYnJpZ2h0bmVzcyA9IGJy aWdodG5lc3M7DQorCQkJfQ0KKwkJfQ0KKwkJQUNQSV9TRVJJQUxfRU5EKHZp ZGVvKTsNCisJCWJyZWFrOw0KKwlkZWZhdWx0Og0KKwkJYnJlYWs7DQorCX0N Cit9DQo= ---496892480-1044077609-1266010709=:5956--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1002122232380.5956>