Date: Sun, 29 Apr 2012 15:25:03 +1000 (EST) From: Ian Smith <smithi@nimnet.asn.au> To: Hiroki Sato <hrs@freebsd.org> Cc: freebsd-ipfw@freebsd.org Subject: Re: CFR: ipfw0 pseudo-interface clonable Message-ID: <20120429150343.H91148@sola.nimnet.asn.au> In-Reply-To: <20120428.231800.306465812317617923.hrs@allbsd.org> References: <20120425.002600.1631867625819249738.hrs@allbsd.org> <4F96D11B.2060007@FreeBSD.org> <20120425.020518.406495893112283552.hrs@allbsd.org> <20120428.231800.306465812317617923.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 28 Apr 2012 23:18:00 +0900 (JST), Hiroki Sato wrote: > A revised patch is attached. The lock around log_if should be fixed > and ipfw(8) manual page is updated. Also, an rc.conf(5) variable > $firewall_logif is added to create ipfw0 interface at boot time (NO > by default). > > Any comments are welcome. Thank you. Only wee nits on form, not function .. + if checkyesno firewall_logif; then + echo 'Firewall logging pseudo-interface (ipfw0) created.' + ifconfig ipfw0 create + fi Strictly, the echo should follow ifconfig success - how picky is that! +++ etc/defaults/rc.conf (working copy) [..] +firewall_logif="NO" # Set to YES to create logging-pseudo interface 'logging pseudo-interface' And firewall_logif needs adding to rc.conf(5)? cheers, Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120429150343.H91148>