Date: Mon, 22 Jun 2015 12:25:18 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Kevin Lo <kevlo@FreeBSD.org> Cc: current@FreeBSD.org, adrian@FreeBSD.org Subject: Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes Message-ID: <20150622092518.GF73119@glebius.int.ru> In-Reply-To: <20150622015123.GA56922@ns.kevlo.org> References: <20150616163436.GP73119@glebius.int.ru> <20150617082855.GT73119@glebius.int.ru> <20150618081655.GA44125@ns.kevlo.org> <20150618104030.GK73119@glebius.int.ru> <20150622015123.GA56922@ns.kevlo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 22, 2015 at 09:51:23AM +0800, Kevin Lo wrote:
K> Thank you Gleb. urtw(4) works fine on amd64.
Thanks.
K> One minor problem, I got an compiler error and this diff below fixes it.
K>
K> --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800
K> +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800
K> @@ -10421,14 +10421,6 @@
K> struct urtw_vap *uvp = URTW_VAP(vap);
K> struct ieee80211_node *ni;
K> usb_error_t error = 0;
K> -@@ -1905,7 +1858,6 @@
K> - default:
K> - break;
K> - }
K> --fail:
K> - URTW_UNLOCK(sc);
K> - IEEE80211_LOCK(ic);
K> - return (uvp->newstate(vap, nstate, arg));
K> @@ -1915,12 +1867,11 @@
K> urtw_watchdog(void *arg)
K> {
This patch is unclear to me. Can you please send a diff between my version
and your version? Diff of diff drives me mad.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150622092518.GF73119>