Date: Sun, 3 Jun 2018 15:21:42 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: David Wolfskill <david@catwhisker.org>, "Alex V. Petrov" <alexvpetrov@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Error build nvidia-driver with r334555 Message-ID: <20180603122142.GM3789@kib.kiev.ua> In-Reply-To: <20180603120834.GT1389@albert.catwhisker.org> References: <83fec8d8-699f-e86c-9884-9d8698a86a91@gmail.com> <20180603120834.GT1389@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 03, 2018 at 05:08:34AM -0700, David Wolfskill wrote: > On Sun, Jun 03, 2018 at 06:48:01PM +0700, Alex V. Petrov wrote: > > .... > > --- nvidia_subr.o --- > > > > > > nvidia_subr.c:367:26: error: 'memset' call operates on objects of type > > 'struct nv_ioctl_card_info' while the size is based on a different type > > 'struct nv_ioctl_card_info *' [-Werror,-Wsizeof > > -pointer-memaccess] > > memset(ci, 0, sizeof(ci)); > > ~~ ^~ > > nvidia_subr.c:367:26: note: did you mean to dereference the argument to > > 'sizeof' (and multiply it by the number of elements)? > > > > memset(ci, 0, sizeof(ci)); > > ^~ > > 1 error generated. > > *** [nvidia_subr.o] Error code 1 > > .... > > Aye; please ref. > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228709>; for > additional details. > > The issue has been narrowed down to the range r334529 - r334535; I'm > suspecting r334533 and/or r334534. (Not that the commits are in any way > "faulty" -- merely that the nvidia-driver port may need some "evasive > action" to allow for the change). Even not looking at the actual code, I am quite sure that the line nvidia_subr.c:367 should be changed to memset(ci, 0, sizeof(*ci)); This is a bug in the driver sources.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180603122142.GM3789>