Date: Mon, 26 Jul 2021 19:50:37 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: =?ISO-8859-1?Q?S=F8ren?= Schmidt <soren.schmidt@gmail.com>, Free BSD <freebsd-arm@freebsd.org> Subject: Re: Quartz64 (RK3566) clock driver and patches. Message-ID: <20210726195037.59165880a49ef24d1cb89833@bidouilliste.com> In-Reply-To: <20210724221706.04662e3c723a2427fdca0f75@bidouilliste.com> References: <FA4E6D58-1E4C-4F7A-B0E5-C231BBAFE6DF@gmail.com> <20210724135600.752789eaa83309c8ab256e1e@bidouilliste.com> <B78363C7-4ED4-426B-AC16-751C0A727C4A@gmail.com> <CB2A74A7-7CC8-40A9-B4EC-174C280A716F@gmail.com> <20210724221706.04662e3c723a2427fdca0f75@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Jul 2021 22:17:06 +0200 Emmanuel Vadot <manu@bidouilliste.com> wrote: > On Sat, 24 Jul 2021 19:46:20 +0200 > S=F8ren Schmidt <soren.schmidt@gmail.com> wrote: >=20 > > On 24 Jul 2021, at 13.56, Emmanuel Vadot <manu@bidouilliste.com <mailto= :manu@bidouilliste.com>> wrote: > >=20 > > >>=20 > > >> On Sat, 24 Jul 2021 13:26:07 +0200 > > >> S=F8ren Schmidt <soren.schmidt@gmail.com <mailto:soren.schmidt@gmail= .com>> wrote: > > >>=20 > > >>> Hi=20 > > >>>=20 > > >>> As promised, the clk driver I did for the RK3566 used on the Pine Q= uartz64 board: > > >>>=20 > > >>> https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~s= os/Q64/> <https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/= ~sos/Q64/>> > > >>>=20 > > >>> Included the buld script, kernel config and u-boot I have used to g= et there. > > >>=20 > > >> That will be much easier to review on phab, or even github PR or git > > >> send-email, basically anything else that this raw diff. > > >>=20 > >=20 > > So for your entertainment I just uploaded the patch to fabricator, howe= ver I dont see how that changes anything but the colors :) >=20 > That will make me look more closely to the patches :) >=20 > Thanks, >=20 > >=20 > > -- > > S=F8ren Schmidt > > sos@deepcore.dk / sos@freebsd.org > > "So much code to hack, so little time" > >=20 > >=20 > >=20 >=20 >=20 > --=20 > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org> >=20 I cannot add comment to the review : You Shall Not Pass: D31299 You do not have permission to edit this object. Looks like you added a custom policy : "sos created this object with edit policy "sos (S=F8ren Schmidt)"." Please remove it and also if you could upload diff with more context too. --=20 Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210726195037.59165880a49ef24d1cb89833>