Date: Wed, 26 Nov 2003 17:40:09 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Sergey Matveychuk <sem@ciam.ru> Cc: ports@FreeBSD.org Subject: Re: PORTVERSION and portlint Message-ID: <1069886409.752.106.camel@gyros> In-Reply-To: <3FC528AD.2050108@ciam.ru> References: <3FC528AD.2050108@ciam.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-xv5gjJB+2Za6ZpHW1DV9
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2003-11-26 at 17:26, Sergey Matveychuk wrote:
> What's wrong with '+' sign in PORTVERSION?
> www/apache13+modssl, russian/apache* and dns/bind9-dlz ports use it for=20
> separating port version and module version. I think it's a good practice.
The idea is to test for PKGVERSIONs that pkg_version cannot handle.=20
However, the '+' notation seems to be correctly handled by pkg_version
on -CURRENT and -STABLE (at least with apache-modssl).
>=20
> But portlint marks it as FATAL. May be make a sense this simple patch to=20
> apply?
Yeah, this makes sense.
Joe
>=20
> ---
> Sem.
>=20
> ______________________________________________________________________
> --- portlint.orig Thu Nov 27 01:22:30 2003
> +++ portlint Thu Nov 27 01:23:04 2003
> @@ -1535,7 +1535,7 @@
> &perror("FATAL: $file: PORTVERSION must be specified");
> }
> if ($portversion =3D~ /^pl[0-9]*$/
> - || $portversion =3D~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9]*)*$=
/) {
> + || $portversion =3D~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9+]*)*=
$/) {
> print "OK: PORTVERSION \"$portversion\" looks fine.\n" if ($verbose);
> } elsif ($portversion =3D~ /^[^\-]*\$[{\(].+[\)}][^\-]*$/) {
> &perror("WARN: $file: using variable, \"$portversion\", as version ".
--=20
Joe Marcus Clarke
FreeBSD GNOME Team :: marcus@FreeBSD.org
gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
--=-xv5gjJB+2Za6ZpHW1DV9
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQA/xSvJb2iPiv4Uz4cRApdNAJ9ge+gGjN7oB9BmBE5sstO2jILpoQCcDgCJ
4CFmjRoIoYnqPW847gi2Ky8=
=EPaU
-----END PGP SIGNATURE-----
--=-xv5gjJB+2Za6ZpHW1DV9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1069886409.752.106.camel>