Date: Fri, 15 Jul 2005 14:40:41 -0700 From: Nate Lawson <nate@root.org> To: Harry Coin <harrycoin@qconline.com> Cc: freebsd-current@FreeBSD.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up Message-ID: <42D82D59.9060605@root.org> In-Reply-To: <4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com> References: <200507121027.14113.jhb@FreeBSD.org> <4.3.2.7.2.20050711121036.02caa348@mail.qconline.com> <200507111626.25124.jhb@FreeBSD.org> <42D2F177.3070101@root.org> <200507121027.14113.jhb@FreeBSD.org> <4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Harry Coin wrote: > At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote: > >> Drivers should not rely on isa_get_logicalid() to determine a boolean >> "is PNP?" > > > The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers > for that purpose. As I understand it, John doesn't like the ugly nature > of passing in a null device list for non-pnp ISA drivers. Hard to > argue with that. > > So why not gin up a tiny little boolean kernel function > 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers > - once -,right after wherever ISA_PNP_PROBE is defined in the kernel? I don't understand how this is needed. ACPI devices are always a superset of PNP. If a probe method is not PNP capable, it should never attach to the ACPI bus. I think that's what his fix changes, and I think it's sufficient. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42D82D59.9060605>