Date: Wed, 13 May 2009 21:57:14 +0200 From: Mel Flynn <mel.flynn+fbsd.current@mailing.thruhere.net> To: freebsd-current@freebsd.org Cc: Tim Kientzle <kientzle@freebsd.org>, Dmitry Morozovsky <marck@rinet.ru>, Garance A Drosehn <gad@freebsd.org> Subject: Re: newsyslog(8) patch for both size and time checks Message-ID: <200905132157.14906.mel.flynn%2Bfbsd.current@mailing.thruhere.net> In-Reply-To: <4A09F850.2080208@freebsd.org> References: <alpine.BSF.2.00.0905121354450.1756@woozle.rinet.ru> <p06240800c62f5d4bab62@[128.113.24.47]> <4A09F850.2080208@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 13 May 2009 00:29:36 Tim Kientzle wrote: > Garance A Drosehn wrote: > > At 1:59 PM +0400 5/12/09, Dmitry Morozovsky wrote: > >> for now, if log is configured to be rotated in time manner, its size > >> is not checked ... > >> > >> The following simple patch should fix the problem. Any objection to > >> commit this? > > > > It would fix your problem, but it changes the behavior as is explicitly > > documented in 'man newsyslog.conf' . There is a paragraph in the man > > page which makes it clear that if both fields are specified, then the > > log file will only be rotated if both conditions are true. > > I've never liked that paragraph and find the > documented behavior is much less useful than the > proposed behavior. I rotate maillogs on not so busy machines using this functionality. The reasoning behind it is that I keep a limited number of logs available and if for some reason the machine starts spewing a lot of mail, I still want to know when it started. I also don't see the point of compressing/rotating 1-10 lines if the machine only sends out the periodic mails, hence this works peachy. > If compatibility is essential, perhaps we could > add a new flag to control this behavior. (I would > argue for changing the default and providing a flag > to obtain the old behavior.) Fine on the flag, maybe mergemaster could be a little more assisting in this case, since I'm not looking forward to "just adding a flag". Like mergemaster -p could auto-upgrade the lines that have both columns with values? -- Mel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905132157.14906.mel.flynn%2Bfbsd.current>