Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 09 Jan 2002 13:47:27 -0800
From:      Peter Wemm <peter@wemm.org>
To:        Sheldon Hearn <sheldonh@starjuice.net>
Cc:        Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/modules/smbfs Makefile 
Message-ID:  <20020109214727.886C738CC@overcee.netplex.com.au>
In-Reply-To: <54456.1010578405@axl.seasidesoftware.co.za> 

next in thread | previous in thread | raw e-mail | index | archive | help
Sheldon Hearn wrote:
> 
> 
> On Wed, 09 Jan 2002 14:04:15 +0200, Ruslan Ermilov wrote:
> 
> > It's not harmless but bogus.  Please back this out.
> > There's no such thing as KMODDEPS in -CURRENT:
> 
> Okay, I took my cue from dummynet, which I assumed used it for
> documentation.

Well, that has been eradicated now. I saw the commit before I saw this
thread.

> > Please also feel free to remove KMODDEPS from
> > sys/modules/dummynet/Makefile.
> 
> I'll remove KMODDEPS from both as soon as I've performed the MFC of the
> smbfs change.  That'll happen as soon as the release engineers approve
> the change.

We dont need to bogofy -current in order to get a change into -stable. It
achieves nothing except waste repo space.  The reasons to commit to
-current first dont apply here.  ie: 1) to make sure that we dont lose
features or bugfixes, and 2) some sort of sanity check on the change. In
this case, 1) is irrelevant since it is already fixed in -current, and 2)
is irrelevant since the change gets no testing whatsoever since it is
completely ignored by the bsd.kmod.mk files.  (I intend to "fix" this so
that we dont get any more of these turn up)

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020109214727.886C738CC>