Date: Wed, 18 Mar 2015 15:32:08 -0600 From: Warner Losh <imp@bsdimp.com> To: Anthony Jenkins <Anthony.B.Jenkins@att.net> Cc: freebsd-acpi@freebsd.org, Ian Smith <smithi@nimnet.asn.au> Subject: Re: [PATCH] ACPI CMOS region support rev. 5 Message-ID: <85F2CFD2-14C1-43D6-8963-0D1F69F17577@bsdimp.com> In-Reply-To: <5509A0EA.4070208@att.net> References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <C47B4C39-A568-47AE-A62F-1DE69CF9E43C@bsdimp.com> <5509A0EA.4070208@att.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Mar 18, 2015, at 9:59 AM, Anthony Jenkins = <Anthony.B.Jenkins@att.net> wrote: >=20 > On 03/18/2015 11:26 AM, Warner Losh wrote: >> Looking at patch 5: >>=20 >> You need to rework this so there=92s an atrtc_acpi.c. Put all the = ACPI attachment in there. >=20 > Okay, shouldn't be a problem. >=20 >> You should also split off the little bit that=92s ISA-specific into = atrtc_isa. >=20 > You mean rtcin() and writertc()? ...but that's not my stuff, it was > already in atrtc.c. PNP0800 (the PC-AT RTC component) is = (practically) > an ISA-specific device. There will be a small =93isa=94 specific driver. Here ISA means =91FreeBSD= ISA attachment=92 not necessarily what you=92d find on an ISA bus. This means you=92d have two = separate driver statement. You can then do the ACPI stuff in the ACPI attachment and not = have to worry about whether or not it is compiled into the kernel, since you=92d only = include it if acpi is in the kernel. Warner --Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVCe7YAAoJEGwc0Sh9sBEAMqEP/RDUi2VmhMFeV7W0+ssMGplt 9/QkjgivDPKvEbWDefm837nI2GY4FlIUIrN8F0r3D7Jr1Ur+NdJPsAimc4uOz/tG UHyG1QgOBG3GB0zuIYSwpJEPZ+ddlWH14vlucCjCoIm8FB1o/TKwHEUdU8OZtPMo 5DplTkwoUXo9vY9iJz+TpiwqR1KXVU5TKN22SrJcdkKLVFPWIpvCc2uXLrtkOp+x OR7v5q+1JxuKBSVSnehMKVeQwPbzBQA93dYswn/4a4kB4IK0oWgxpdHc0SvAt8vz AB/SlBWQySeB9QHQbSGRE8VxvTIFYmMHyAcBTdKS8ohf7JNi0zgHGNUHoer+HmW9 wcXFKR/y7tG6xiIDnH/yXlcQ/eQ3xXed/ZW/hG+cuKfoG8X0kd+bb0nQ99NeYFvG C10OGvew/2fk5yf2AobVtgzdxT3VL2mLGl1hqN6jJnpIfs4zAyOTFT/dg4UnZpIA rWD6mhBUd03GZ2OISEiLtI3m3AsQ4DDsjHRTXcMoa+rgCXISXcroHINax1e4FI5s IjPRfiswlmWFxaLnqoSwYPxfxvMbemeqDN3hCvIv6K6APVIPPGi31yDmL2O07U+R iF9Qvrf2f/g1VCXIkHsti53MV8qGwucUkwTzd4sUqKKPyg+AoNKq1gdcPORjd9qd L5wzrgal1kwpYDdBd7BS =+RsP -----END PGP SIGNATURE----- --Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85F2CFD2-14C1-43D6-8963-0D1F69F17577>