Date: Thu, 8 Feb 2018 13:32:18 +0100 From: Maurizio Vairani <maurizio1018@gmail.com> To: John Nielsen <lists@jnielsen.net> Cc: freebsd-current <freebsd-current@freebsd.org>, Daisuke Aoyama <aoyama@peach.ne.jp>, Ian Lepore <ian@freebsd.org> Subject: Re: Fatal trap 12 booting FreeBSD-CURRENT via isboot kernel module. Message-ID: <CAN0zgYWmEAoHYk=sir97AYH2MB-F70nBrgwuqh4dsMKSse5Ccw@mail.gmail.com> In-Reply-To: <7D39479C-85AB-45B2-BF39-0566AC073C5A@jnielsen.net> References: <CAN0zgYXfKjKo3CjjfbEX7oSrd2NXqU6kmSXy__OVPr0y3R2Log@mail.gmail.com> <3E242843-7D43-4A36-A448-E4B0DACB2AB4@jnielsen.net> <CAN0zgYWY0QqjHNfnVmOv%2B06H8qAvjKu0N7qvSMgcUo7vi6Bt-A@mail.gmail.com> <DC546197-0C18-4C2A-8E5D-AF6846AA94F3@jnielsen.net> <5EDB0747-41DE-4ECF-925E-EF24FAA550F3@jnielsen.net> <1517943001.1366.100.camel@freebsd.org> <1C97132B-099B-4BAA-9C39-A1BE00481CAC@jnielsen.net> <CAN0zgYXw%2BWvGJKFRV0VjSCZdFKDCuWAoUcBQ8dPXA4qtvkCtWg@mail.gmail.com> <7D39479C-85AB-45B2-BF39-0566AC073C5A@jnielsen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
2018-02-07 19:29 GMT+01:00 John Nielsen <lists@jnielsen.net>: > > On Feb 7, 2018, at 6:07 AM, Maurizio Vairani <maurizio1018@gmail.com> > wrote: > > > > 2018-02-06 23:02 GMT+01:00 John Nielsen <lists@jnielsen.net>: > > > On Feb 6, 2018, at 11:50 AM, Ian Lepore <ian@FreeBSD.org> wrote: > > > > > > On Tue, 2018-02-06 at 11:33 -0700, John Nielsen wrote: > > >> > > >> Apparently sending a NULL socket pointer to ifioctl hasn't worked > > >> since this commit in 2011: > > >> https://svnweb.freebsd.org/base?view=revision&revision=218757 > > >> > > >> So I'm going to add this patch to the port unconditionally once it > > >> works. > > >> > > >> Unfortunately, I can't compile the port with either my patch below or > > >> your original replacement version of isboot_ifup(). :( Did you make > > >> other changes? Here's the error I'm getting: > > >> > > >> --- isboot.o --- > > >> isboot.c:425:53: error: incomplete definition of type 'struct thread' > > >> error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td); > > >> ~~^ > > >> /usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct > > >> thread' > > >> struct thread; > > >> ^ > > >> 1 error generated. > > >> > > > > > > Try adding #include <sys/proc.h> if it's not already in the list. It > > > may be that that file got included via pollution from some other header > > > file in the past and maybe now that has changed. > > > > > > If you're already including sys/proc.h then I'm clueless. > > > > Thanks Ian, that appears to work. > > > > Maurizio, can you apply the attached patch to a clean ports tree and see > if isboot-kmod will build and function properly for you? This is all the > changes from this thread and the previous one. If you let me know it works > I'll get the port updated. > > > > > > Hi John, I need some help. > > > > I am running: > > # uname -a > > FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 > 04:48:52 UTC 2018 root@releng3.nyi.freebsd.org:/ > usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 > > > > after upgrading the ports tree with: > > # portsnap fetch update > > > > I have copied the directory /usr/ports/net/isboot-kmod/ in > /root/src/isboot-kmod and /root/src/isboot-kmod.orig > > # ls -l /root/src > > total 6 > > drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod > > drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig > > -rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt > > > > Trying to apply the patch I obtain the error: > > # cd /root/src > > # patch -sC < isboot_patch.txt > > 2 out of 2 hunks failed while patching isboot-kmod/Makefile > > 5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c > > > > What I am missing ? > > Thanks again for your work. > > Not sure but I ran in to similar issues testing here as well. Here's the > "svn diff" patch which does work for me. Note that this one should be > applied from within the isboot-kmod directory. > > With this patch I receive this error : # pwd /root/src/isboot-kmod # patch -sC < ../isboot-kmod-0.2.13_2.diff.txt 2 out of 2 hunks failed while patching Makefile 5 out of 5 hunks failed while patching files/patch-isboot.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN0zgYWmEAoHYk=sir97AYH2MB-F70nBrgwuqh4dsMKSse5Ccw>