Date: Fri, 26 Jun 2015 10:45:30 -0400 From: Anthony Jenkins <Anthony.B.Jenkins@att.net> To: "Moore, Robert" <robert.moore@intel.com>, Ian Smith <smithi@nimnet.asn.au>, Warner Losh <imp@bsdimp.com> Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org> Subject: Re: [PATCH] ACPI CMOS region support rev. 6 Message-ID: <558D658A.2080807@att.net> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30820A@ORSMSX112.amr.corp.intel.com> References: <20150222180817.GD27984@strugglingcoder.info> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <20150317222704.K22641@sola.nimnet.asn.au> <550825DE.7030406@att.net> <56B494A3-2058-4B7B-8183-646A46753A53@bsdimp.com> <5509A282.6070207@att.net> <D1E7A1AE-51FD-4BFB-A861-13E16F95BB77@bsdimp.com> <20150319184348.X22641@sola.nimnet.asn.au> <550ACAEC.3060808@att.net> <20150320002950.T22641@sola.nimnet.asn.au> <550AD9B7.4090508@att.net> <558CA785.1050904@att.net> <558CA7C9.9000304@att.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D30820A@ORSMSX112.amr.corp.intel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/25/2015 10:33 PM, Moore, Robert wrote: > How do you handle the fact that there are three different CMOS/RTC devices defined in the ACPI specification? (There are three different _HIDs). Right, each of the three CMOS/RTC devices in the ACPI spec has a different ACPI ID (PNP0B00, PNP0B01, PNP0B02). FreeBSD's CMOS RTC driver only attaches to PNP0B00; if a different CMOS device is present, there will be no CMOS/RTC driver (since we don't know how to talk to it). Should be a no-op, like for any unsupported device. If I had the specs for each of those devices, I could probably cobble together support for the other two, but that wasn't my original mission... Anthony > >> -----Original Message----- >> From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >> acpi@freebsd.org] On Behalf Of Anthony Jenkins >> Sent: Thursday, June 25, 2015 6:16 PM >> To: Ian Smith; Warner Losh >> Cc: freebsd-acpi@freebsd.org >> Subject: Re: [PATCH] ACPI CMOS region support rev. 6 >> >> ...and of course I forget the attachment... >> >> On 06/25/15 21:14, Anthony Jenkins wrote: >>> Sooo here's the new and improved rev. 6, "new and improved" because it >>> increases the diff line count by 332%. >>>> [ajenkins@ajenkins-hplaptop /usr/src]$ wc -l atrtc_c_rev5.diff >>>> atrtc_rev6.diff >>>> 220 atrtc_c_rev5.diff >>>> 731 atrtc_rev6.diff >>> This is to satisfy the request to split the atrtc.c driver into a "core" >>> part and "bus" parts: >>>> Looking at patch 5: >>>> >>>> You need to rework this so there's an atrtc_acpi.c. Put all the ACPI >> attachment in there. You should also split off the little bit that's ISA- >> specific into atrtc_isa. Once you do that, we can talk. >>>> Warner >>> I actually finished this patch a couple months ago and have been >>> running it on my laptop, I just don't see the point...maybe Warner >>> could elaborate on the rationale for his request? At the very least, >>> this should be two commits - the functional change and the >>> refactorization request. >>> >>> I may have also added Ian's request for verbosity tweaks, but it's >>> been a while... I don't see any CMOS logging noise FWIW. >>> >>> Thanks, >>> Anthony >>> >>> > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?558D658A.2080807>