Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Oct 2014 18:56:10 +0200
From:      Enrico Maria Crisostomo <enrico.m.crisostomo@gmail.com>
To:        Craig Rodrigues <rodrigc@freebsd.org>
Cc:        ports <freebsd-ports@freebsd.org>
Subject:   Re: Patching a Java package substituting a precompiled class
Message-ID:  <8045F402-93AE-4A96-8035-B04B5F76DFD9@gmail.com>
In-Reply-To: <CAG=rPVf8Sc5WG31Beh=cs7JABL82ofDtSW5rpL4ZwQC%2BdRGh=w@mail.gmail.com>
References:  <F5829461-F030-4274-8DF8-ECBA8A832A63@gmail.com> <CAG=rPVf8Sc5WG31Beh=cs7JABL82ofDtSW5rpL4ZwQC%2BdRGh=w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_10BDD957-C916-4720-8ED9-512DC41C05FF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

Hi Craig,

You and all the FreeBSD community are welcome: I do that because I do =
want FreeBSD to be alive and kicking.

Thanks for that suggestion: I like it and I'm updating the port right =
now.  logstash contains the jruby jar which in turn contains the jnr-ffi =
classes: I've got to patch the jar anyway in order to substitute the =
affected classes, but at least I'm grabbing the binaries (logstash and =
my jnr-ffi fork) using DISTFILES.

In the meantime I'll periodically ping that PR.

Thank you very much Craig,=20
--=20
Enrico

> On 19 Oct 2014, at 02:24, Craig Rodrigues <rodrigc@freebsd.org> wrote:
>=20
> On Sat, Oct 18, 2014 at 1:07 PM, Enrico Maria Crisostomo =
<enrico.m.crisostomo@gmail.com> wrote:
> Hi,
>=20
> I=92m trying to fix a Java port (logstash) that's crashing in FreeBSD =
because of a bug in a Java class in a JAR that's included as a =
dependency.  Three different persons, included I, have submitted a PR =
upstream (you can see mine here: https://github.com/jnr/jnr-ffi/pull/26) =
but the activity in that project is pretty slow and nobody has taken =
action yet.
>=20
>=20
> Thanks for doing that.  I lot of people in the Java world
> don't care much about FreeBSD, so this process can be painful.
>=20
> There is another option that you may wish to consider.
>=20
> (1)  Take your https://github.com/emcrisostomo/jnr-ffi/ fork on =
github.
>=20
> (2)  Make a release of the jnr package and put it at =
https://github.com/emcrisostomo/jnr-ffi/releases/
>=20
> (3)  Change the FreeBSD port to use your version of jnr
>=20
> (4)  When the upstream version of jnr changes to accept your patch, =
delete your fork, and change the port back to using the original jnr.
>=20
> Thanks for doing this.  It takes some pushing but eventually upstream =
will take our patches.  I did the same thing for =
https://github.com/jenkinsci/jenkins/pull/1387 and Jenkins.
>=20
> --
> Craig


--Apple-Mail=_10BDD957-C916-4720-8ED9-512DC41C05FF
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMgTCCBjQw
ggQcoAMCAQICAR4wDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0
Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcxKTAn
BgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3MTAyNDIxMDE1NVoX
DTE3MTAyNDIxMDE1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSsw
KQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFy
dENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQTCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBAMcJg8zOLdgasSmkLhOrlr6KMoOMpohBllVHrdRvEg/q6r8jR+EK
75xCGhR8ToREoqe7zM9/UnC6TS2y9UKTpT1v7RSMzR0t6ndl0TWBuUr/UXBhPk+Kmy7bI4yW4urC
+y7P3/1/X7U8ocb8VpH/Clt+4iq7nirMcNh6qJR+xjOhV+VHzQMALuGYn5KZmc1NbJQYclsGkDxD
z2UbFqE2+6vIZoL+jb9x4Pa5gNf1TwSDkOkikZB1xtB4ZqtXThaABSONdfmv/Z1pua3FYxnCFmdr
/+N2JLKutIxMYqQOJebr/f/h5t95m4JgrM3Y/w7YX9d7YAL9jvN4SydHsU6n65cCAwEAAaOCAa0w
ggGpMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBRTcu2SnODaywFc
fH6WNU7y1LhRgjAfBgNVHSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRa
MFgwJwYIKwYBBQUHMAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYh
aHR0cDovL3d3dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6
Ly93d3cuc3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5j
b20vc2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0
dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93d3cu
c3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBAAqDCH14qywG
XLhjjF6uHLkjd02hcdh9hrw+VUsv+q1eeQWB21jWj3kJ96AUlPCoEGZ/ynJNScWy6QMVQjbbMXlt
UfO4n4bGGdKo3awPWp61tjAFgraLJgDk+DsSvUD6EowjMTNx25GQgyYJ5RPIzKKR9tQW8gGK+2+R
HxkUCTbYFnL6kl8Ch507rUdPPipJ9CgJFws3kDS3gOS5WFMxcjO5DwKfKSETEPrHh7p5shuuNktv
sv6hxHTLhiMKX893gxdT3XLS9OKmCv87vkINQcNEcIIoFWbP9HORz9v3vQwR4e3ksLc2JZOAFK+s
sS5XMEoznzpihEP0PLc4dCBYjbvSD7kxgDwZ+Aj8Q9PkbvE9sIPP7ON0fz095HdThKjiVJe6vofq
+n6b1NBc8XdrQvBmunwxD5nvtTW4vtN6VY7mUCmxsCieuoBJ9OlqmsVWQvifIYf40dJPZkk9YgGT
zWLpXDSfLSplbY2LL9C9U0ptvjcDjefLTvqSFc7tw1sEhF0n/qpA2r0GpvkLRDmcSwVyPvmjFBGq
Up/pNy8ZuPGQmHwFi2/14+xeSUDG2bwnsYJQG2EdJCB6luQ57GEnTA/yKZSTKI8dDQa8Sd3zfXb1
9mOgSF0bBdXbuKhEpuP9wirslFe6fQ1t5j5R0xi72MZ8ikMu1RQZKCyDbMwazlHiMIIGRTCCBS2g
AwIBAgIDCFuNMA0GCSqGSIb3DQEBCwUAMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRD
b20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYG
A1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0EwHhcN
MTMxMjExMTUyNzM5WhcNMTQxMjEyMDkyMjAxWjBWMSYwJAYDVQQDDB1lbnJpY28ubS5jcmlzb3N0
b21vQGdtYWlsLmNvbTEsMCoGCSqGSIb3DQEJARYdZW5yaWNvLm0uY3Jpc29zdG9tb0BnbWFpbC5j
b20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDRT2LNGT66xvt23639dtvMMLt2dDVU
GZCKYOPK3uwl6uxIUsm4P4IPwnE+RMaEFgkGck7fHv/MPlVtJebXmMWv9/XVuahRMRiyp7taw0y7
72wRRqfukQbrHEsuJ+xVkwUTR9vZpM13K0Ity0PvkRmSVlGncG96UBJ4Ye+E/l9jo77j6V44rOGo
BLvHR6wlD0cSccLaN0XhkQLu3Gfd2C/201nUY7E0EBZWSaFLBf9AubRuq4HbQWrgaUf3/sOZH+pG
qoD8/fYGipdVYcUVjh5w4Yc1pBwrVeiluuT8sZ3C28S2x/YWrWwNV7QqpXGSV5Lp6afl43rF42h1
YPOACoRBAgMBAAGjggLjMIIC3zAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHSUEFjAUBggr
BgEFBQcDAgYIKwYBBQUHAwQwHQYDVR0OBBYEFFRCm6UtWNAmeycalMMRIlGuHH6oMB8GA1UdIwQY
MBaAFFNy7ZKc4NrLAVx8fpY1TvLUuFGCMCgGA1UdEQQhMB+BHWVucmljby5tLmNyaXNvc3RvbW9A
Z21haWwuY29tMIIBTAYDVR0gBIIBQzCCAT8wggE7BgsrBgEEAYG1NwECAzCCASowLgYIKwYBBQUH
AgEWImh0dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwgfcGCCsGAQUFBwICMIHqMCcW
IFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MAMCAQEagb5UaGlzIGNlcnRpZmljYXRl
IHdhcyBpc3N1ZWQgYWNjb3JkaW5nIHRvIHRoZSBDbGFzcyAxIFZhbGlkYXRpb24gcmVxdWlyZW1l
bnRzIG9mIHRoZSBTdGFydENvbSBDQSBwb2xpY3ksIHJlbGlhbmNlIG9ubHkgZm9yIHRoZSBpbnRl
bmRlZCBwdXJwb3NlIGluIGNvbXBsaWFuY2Ugb2YgdGhlIHJlbHlpbmcgcGFydHkgb2JsaWdhdGlv
bnMuMDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuc3RhcnRzc2wuY29tL2NydHUxLWNybC5j
cmwwgY4GCCsGAQUFBwEBBIGBMH8wOQYIKwYBBQUHMAGGLWh0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNv
bS9zdWIvY2xhc3MxL2NsaWVudC9jYTBCBggrBgEFBQcwAoY2aHR0cDovL2FpYS5zdGFydHNzbC5j
b20vY2VydHMvc3ViLmNsYXNzMS5jbGllbnQuY2EuY3J0MCMGA1UdEgQcMBqGGGh0dHA6Ly93d3cu
c3RhcnRzc2wuY29tLzANBgkqhkiG9w0BAQsFAAOCAQEAv7bVFNp6SmYLMKinPm/y4ZmG2pytnEMh
34tNrVhPqbYF4yAYw3UdlkmU4wS4GUEAbcMTTJWL5jIZ0JwpkVgUdN9VtDlIuZF7evuWB9LAx5re
TAZJ4FR11/Q4AGE4Hs0PvT8i4dvug8IFhx1DLXMA14ypFdcC1+f46uxTJ1//nQTv3wuhdJdarPI5
K5NHzfL+pK+/3Gn7RcfgbAjp2MSEsnV20PmWWLDd+aO+NVW22+YjaOT/c3fnp2NTk3tPm9t7rUkK
xcRHrcFNjurmYIIbWUBJ2XosnxdWVkA7JvIS5wAOsI5RZcYA6/0FqltjCIyZ+YsP+Rs3Mlp8ra3l
7KKN7DGCA28wggNrAgEBMIGUMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRk
LjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMv
U3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0ECAwhbjTAJBgUr
DgMCGgUAoIIBrzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xNDEw
MjAxNjU2MTBaMCMGCSqGSIb3DQEJBDEWBBQea9ET/8wkUwQATEO87BQcvFoKnTCBpQYJKwYBBAGC
NxAEMYGXMIGUMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UE
CxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20g
Q2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0ECAwhbjTCBpwYLKoZIhvcNAQkQ
AgsxgZeggZQwgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQL
EyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBD
bGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQQIDCFuNMA0GCSqGSIb3DQEBAQUA
BIIBAIkHRT4ipBp5xqptwV8FWRQIJWh2RT6nVa/DVkd5qO4M9f04AUIMBao6AsV0O/kPSZvFMCZH
lHg3AZXpgpZMlQ9hvtMISoPwYkIRt1rN1UYd9tvbsJ0EaT1SMxZBVZi8fZHYFX+i9ZqNMoO3EVRV
pYZyYePb0KUSoK6dXk3BhhgiJox7QlqQxgnSqrv5ZyTXO0DjnbygXYcAyiZfi2Na2IldFZ28bbHJ
jXe2kIkc54U/AuaA5upmFmi7XDj3qLJqRu+1WAHPc3oZ0JS9KB+wul+NsGi6N3OEvnx0djbvV4wY
y2U+IYBcU133VLL6PByZ8G0Gl2aimaFXsUxJJDLwUEAAAAAAAAA=
--Apple-Mail=_10BDD957-C916-4720-8ED9-512DC41C05FF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8045F402-93AE-4A96-8035-B04B5F76DFD9>