Date: Sat, 27 Aug 2016 01:39:08 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org> Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang Message-ID: <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org> In-Reply-To: <CAGHfRMCZ9Ma%2B9wfFJ%2BKFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com> References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> <CAGHfRMCZ9Ma%2B9wfFJ%2BKFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 27 Aug 2016, at 01:12, Ngie Cooper <yaneurabeya@gmail.com> wrote: > > On Fri, Aug 26, 2016 at 3:56 PM, Dimitry Andric <dim@freebsd.org> wrote: >> Author: dim >> Date: Fri Aug 26 22:56:23 2016 >> New Revision: 304868 >> URL: https://svnweb.freebsd.org/changeset/base/304868 >> >> Log: >> Add forgotten {llvm,clang}.pre.mk files. > ... >> +LLVM_SRCS= ${.CURDIR}/../../../contrib/llvm > > Please use ${SRCTOP}/contrib/llvm instead. I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the latter didn't work for builds which are started during bootstrap-tools. So I locally reverted all these changes before committing this WIP. That said, ${SRCTOP} makes it look a little nicer, but there are lots of other instances of using ../../.. in these Makefiles. It does not really bother me. :) -Dimitry --Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlfA0xwACgkQsF6jCi4glqNQ/QCeKeOwa5hZYEJEnAe94gf11t5e h4EAnReJPjYuT7JBJsP3GFd/HZ0SCO39 =Okgk -----END PGP SIGNATURE----- --Apple-Mail=_3F3ADA8A-B76D-4696-A39E-707A7E548437--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A241E349-C7E3-490F-ADC9-D25ABCE956B6>