Date: Thu, 17 May 2018 19:29:28 -0400 From: "John W. O'Brien" <john@saltant.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: Practice of "Sponsored by" in commit messages Message-ID: <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> In-Reply-To: <CAH7qZfu6j%2Bc-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> References: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com> <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <CAH7qZfu6j%2Bc-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W Content-Type: multipart/mixed; boundary="zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu"; protected-headers="v1" From: "John W. O'Brien" <john@saltant.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Message-ID: <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> Subject: Re: Practice of "Sponsored by" in commit messages References: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com> <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <CAH7qZfu6j+c-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> In-Reply-To: <CAH7qZfu6j+c-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> --zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018/05/17 19:18, Maxim Sobolev wrote: > John, no, not really, sorry. Work is done, credit is given. The form an= d > amount of this credit is between whoever does the work and whoever is > being credited. I don't see why is there any third-party to be involved= > in governing whether or not this credit is "appropriate", "sufficient" > or "all encompassing" for the work in question. This is just a credit, > it does not affect the quality of work, nor the license (which is > 2-clause BSD) nor the copyright holder. Three things that really matter= > long-time. So "Sponsored by" it's just the message on the t-shirt, > having only meaning to whoever produces the piece and whoever wears it,= > but nothing in particular to the outside world. IMHO. I fear that you and I are still not on the same page. The difference between a t-shirt and a commit message is that two or three or four people can all do work on the same commit, but only one person can wear a t-shirt. Taking the analogy further, if you hang a t-shirt with your employer's logo on a piece of work that you and I collaborated to produce, don't you think my employer might feel slighted? What if I had done 80% of the work? > On Thu, May 17, 2018 at 3:43 PM, John W. O'Brien <john@saltant.com > <mailto:john@saltant.com>> wrote: >=20 > On 2018/05/14 20:14, Maxim Sobolev wrote: > > What's wrong with a current practice. Why is it of any concern to= you, > > John? Just curious that is not very clear from your message. It i= s like > > someone trying to moderate what people in general or some group i= n > > particular (e.g. freebsd committers) are allowed to put on their > > t-shirts just because you find it offensive or inappropriate. >=20 > I don't find crediting sponsors offensive nor inappropriate. Quite = the > contrary. What I find problematic is when multiple people do work, = not > all with sponsorship or the same sponsorship, and only one person's= > sponsor is mentioned in a way that seems to imply that all the work= was > sponsored. >=20 > What I'm proposing is not to end or ban the practice, but to improv= e and > refine it so that sponsors are credited for what they sponsor and n= ot > for what they don't sponsor. >=20 > Is that clearer? >=20 > > On Mon, May 14, 2018, 4:40 PM John W. O'Brien <john@saltant.com <= mailto:john@saltant.com> > > <mailto:john@saltant.com <mailto:john@saltant.com>>> wrote: > > > >=C2=A0 =C2=A0 =C2=A0Hello FreeBSD Ports, > > > >=C2=A0 =C2=A0 =C2=A0The Committer's Guide section on Commit Log Me= ssages [0], > doesn't cover > >=C2=A0 =C2=A0 =C2=A0the use of the "Sponsored by" key word. As a n= on-committer > contributor, > >=C2=A0 =C2=A0 =C2=A0it only recently occurred to me to wonder what= work that credit is > >=C2=A0 =C2=A0 =C2=A0intended to represent, and whether some light = definition would be > >=C2=A0 =C2=A0 =C2=A0helpful to reduce ambiguity. > > > >=C2=A0 =C2=A0 =C2=A0When a committer credits a sponsor of theirs, = from which the > contributor > >=C2=A0 =C2=A0 =C2=A0received no sponsorship, the portrayal feels a= little awkward. > Does this > >=C2=A0 =C2=A0 =C2=A0strike the list as a problem, and if so, how o= ught it be solved? > > > >=C2=A0 =C2=A0 =C2=A0To make this concrete, allow me to illustrate = the situation. > > > >=C2=A0 =C2=A0 =C2=A0Alice, working on her own time, prepares and c= ontributes a > patch. Bob, > >=C2=A0 =C2=A0 =C2=A0who works for Acme Corp, reviews and commits t= he patch on > company time. > >=C2=A0 =C2=A0 =C2=A0The commit message includes "Sponsored by: Acm= e Corp". Alice > eagerly > >=C2=A0 =C2=A0 =C2=A0awaits her check from Acme Corp. Should the co= mmit message > have read > >=C2=A0 =C2=A0 =C2=A0"Sponsored by: Acme Corp (Bob)"? > > > >=C2=A0 =C2=A0 =C2=A0This could be extensible to multiple sponsorsh= ips. If, > instead, Alice > >=C2=A0 =C2=A0 =C2=A0prepares the patch having received a grant to = do so from Best > Sys Dev, > >=C2=A0 =C2=A0 =C2=A0the commit message could state "Sponsored by: = Acme Corp (Bob), > Best Sys > >=C2=A0 =C2=A0 =C2=A0Dev (Alice)". > > > >=C2=A0 =C2=A0 =C2=A0[0] > >=C2=A0 =C2=A0 > =C2=A0https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committe= rs-guide/article.html#commit-log-message > <https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-gu= ide/article.html#commit-log-message> > > > >=C2=A0 =C2=A0 =C2=A0PS: I realize that this issue transcends ports= , but it's not > clear where > >=C2=A0 =C2=A0 =C2=A0I should send this instead, and this list seem= s like it would > have a > >=C2=A0 =C2=A0 =C2=A0reasonably high concentration of people with a= stake in the > discussion. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu-- --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr+EFkACgkQWPtK56pP /m4LQQgAhjViefg1gNeusXV7QGV7vgDHVNWG0FRVQRvxhxy1dQtuf6R7GzqGPEcD MuCjOJzn/WwZIA4htRzpS+JyLoJGc+Ad8FhCcLKM2rCDP+L4RtQrxC3x6WDwd8Ga SExhRbWSq54+pZ0EwEZNlNq1ekGa880rU7k9XMobnjFBBZQR/uya50vxQeiYGQSo J+X86KuWMD+KFpthYXUw9faaVIwfpHY5Da5YeueCael6ViYpVhqsY70XuhGcPzhE KkLpHxW6G/h4qhWn3/XnWXEpfiZ25V/Kbclc1Q2Rdyzw8CbiZuXg/1WChlax8zVm YbEUmYTiCz9wCWVbwdyqj4SIuQqtdQ== =Hkn5 -----END PGP SIGNATURE----- --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?732c3f40-1765-6883-dbec-f5c77db8e30c>