Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jul 2014 11:25:07 -0700
From:      Peter Grehan <grehan@freebsd.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r268837 - head/sys/netinet
Message-ID:  <53C96683.9070902@freebsd.org>
In-Reply-To: <CAJ-VmonRRZPi%2BRkGQk25xrXGf9BOhHXvAVhRWse%2BfXKduoJ19g@mail.gmail.com>
References:  <201407180822.s6I8MD5a023838@svn.freebsd.org>	<53C94F61.5020706@freebsd.org> <CAJ-VmonRRZPi%2BRkGQk25xrXGf9BOhHXvAVhRWse%2BfXKduoJ19g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Adrian,

> Hah! I wonder why the key from the T3 NIC that Robert committed was so
> .. terrible then.
>
> Are you saying that the actual byte order is totally reversed, or just endian?

  The 32-bit word order of your array is reversed. The last 4 bytes 
should be the first, etc. Have a look at the values in the Microsoft spec.

> I think that was Roberts main concern with using a randomised key at
> startup. It sounds Netapp have already done a lot of the work that I
> was thinking about in the back of my mind - I'll add that to my TODO
> list so we can write a random key generation function at boot time.

  It's still useful to select the Microsoft value e.g. with a tunable, 
since it allows easy verification when folk are implementing RSS.

later,

Peter.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53C96683.9070902>