Date: Fri, 11 Jul 2003 13:18:11 -0700 (PDT) From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: current@freebsd.org Subject: Re: Witness panic (fxp/polling related) Message-ID: <20030711131726.D8593@root.org> In-Reply-To: <200307110913.02566.jhb@FreeBSD.org> References: <EE3D3FBAFFCAED448C21C398FDAD91AC010833@EBE1.gc.nat> <200307110913.02566.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 Jul 2003, John Baldwin wrote:
> if (ether_poll_register(fxp_poll, ifp)) {
> /* disable interrupts */
> CSR_WRITE_1(sc, FXP_CSR_SCB_INTRCNTL, FXP_SCB_INTR_DISABLE);
> fxp_poll(ifp, 0, 1);
> FXP_UNLOCK(sc);
> return;
>
> Try moving the FXP_UNLOCK() up before the call to fxp_poll() (it
> should be safe to do so).
I looked it over and indeed this is the correct fix. Please commit.
Thanks,
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030711131726.D8593>