Date: Mon, 07 Jul 2008 17:42:08 +0900 (JST) From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> To: xcllnt@mac.com Cc: marcel@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 144741 for review Message-ID: <20080707.174208.94913728.nyan@jp.FreeBSD.org> In-Reply-To: <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com> References: <200807051943.m65JhHZ6066371@repoman.freebsd.org> <20080706.110943.226722229.nyan@jp.FreeBSD.org> <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com> Marcel Moolenaar <xcllnt@mac.com> writes: > > These are wrong. RSA98-III is based on ns8250 and has extended FIFO > > buffer. So I think that the uart_rsa_class should be added. > > Oh. In your patch you define it as i8251. I only refactored > the code. Also, the ns8250 class already supports extended > FIFOs, so we don't need a separate class for that. I'll > change it... No. My code set sc_class to uart_rsa_class. It's your mistake. And then I found another problem in uart_bus_isa.c. In your code non-PnP devices for pc98 cannot probe. My original code was no problem... And, RSA has extra registers to control its FIFO buffer. So we need additional code to support it. See: sys/dev/ic/rsa.h and sys/pc98/cbus/sio.c --- TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080707.174208.94913728.nyan>