Date: Mon, 11 Sep 2000 23:33:57 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Boris Popov <bp@butya.kz> Cc: Doug Rabson <dfr@nlsystems.com>, John Baldwin <jhb@pike.osd.bsdi.com>, Doug Rabson <dfr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h Message-ID: <Pine.BSF.4.21.0009112324590.1193-100000@besplex.bde.org> In-Reply-To: <Pine.BSF.4.10.10009111836470.30757-100000@lion.butya.kz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Sep 2000, Boris Popov wrote: > On Mon, 11 Sep 2000, Bruce Evans wrote: > > > > I'll replace it with KASSERT-like definition: > > > > > > #define NULLFSDEBUG(args) printf args > > > > > > with appropriate changes to the rest of the code. > > > > I had almost accepted it. Is the only problem with the KASSERT-like > > definition that double parentheses must be used when it is invoked? > > This has the same problem as ITR* -- it messes up all invocations > > of the macros. > > I think double parentheses more readable in compare with three > lines of #ifdef/blah/#endif. In this case they are at the beginning and > the end of invocation, so code doesn't turn to a mess. I meant that requiring double parentheses or arg counts in the macro names is messy compared with not requiring these. Then when variadic macros become portable, there will be too many invocations to change. Actually, the arg counts are a bit worse -- they have to be counted manually. Parentheses are only hard to count when there are more than 2 of them :). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009112324590.1193-100000>