Date: Wed, 10 Mar 2004 11:49:39 +0100 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/64027: [Maintainer] lang/pnet* -- add PORTDOCS andmissing lib for X support. Message-ID: <404EF2C3.4060103@fillmore-labs.com> In-Reply-To: <Pine.BSF.4.53.0403101009050.843@e0-0.zab2.int.zabbadoz.net> References: <200403100950.i2A9o88s074438@freefall.freebsd.org> <Pine.BSF.4.53.0403101009050.843@e0-0.zab2.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Bjoern A. Zeeb wrote:
> On Wed, 10 Mar 2004, Oliver Eikemeier wrote:
>
>
>>The following reply was made to PR ports/64027; it has been noted by GNATS.
>>
>>From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
>>To: michael johnson <ahze@ahze.net>
>>Cc: freebsd-gnats-submit@FreeBSD.org
>>Subject: Re: ports/64027: [Maintainer] lang/pnet* -- add PORTDOCS and missing
>> lib for X support.
>>Date: Wed, 10 Mar 2004 10:39:54 +0100
>>
>> michael johnson wrote:
>>
>> > +.ifndef(PORTDOCS)
>> > +.for plistfile in ${DOC_FILES}
>> > +PLIST_FILES+= share/doc/${PORTNAME}/${plistfile}
>> > +.endfor
>> > +PLIST_DIRS+= share/doc/${PORTNAME}
>> > +.endif
>> > +
>>
>> You could write
>> PORTDOCS= ${DOC_FILES}
>> instead
>
> if he installs documentations to DOCSDIR why not simply use
> (what Greg lately pointed me to) ?
>
> .if !defined(NOPORTDOCS)
> PORTDOCS= *
> .endif
You are right, this is fine if you are sure that you own *all* documents in
DOCSDIR (which ports usually do). It may be inappropriate when ports share
DOCSDIR, like exim and the exim-doc-* ports. I didn't read the ports
thoroughly enough to be on the safe side, so I decided to simply use
DOC_FILES. Feel free to use whatever suits you best.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?404EF2C3.4060103>