Date: Sat, 16 Dec 2000 10:45:59 -0800 (PST) From: John Baldwin <jhb@FreeBSD.ORG> To: Robert Watson <rwatson@FreeBSD.ORG> Cc: smp@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys proc.h Message-ID: <XFMail.001216104559.jhb@FreeBSD.org> In-Reply-To: <Pine.NEB.3.96L.1001216123826.30174C-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-Dec-00 Robert Watson wrote: > > BTW, I don't know if you've had a chance to look at individual process > locking in kern_proc.c yet, but if so then the sysctl code to retrieve > process info will need some of the same work during kproc_info extraction > (protecting pcred, etc). Also, p_can* will have to assume that the > process mutexes for p1 and p2 are both already held (so as to avoid > recursion issues), so callers of p_can (especially in procfs and > signalling code) will need to reflect that assumption. We should grep > through for any direct references to p_cred throughout the tree, and where > possible eliminate them by improving authorization abstractions (if I > missed any inter-process calls), and where not, make sure they're properly > protected and documented (get/set-uid calls, sysctl, etc). Hmm, ok. I think I've seen one direct p_cred reference that wasn't to pc_ucred so far in sys/compat/svr4. I'll have to look at p_can* in a little more detail. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001216104559.jhb>