Date: Tue, 15 Dec 2020 09:40:16 +0100 From: Michael Gmelin <freebsd@grem.de> To: Matthias Apitz <guru@unixarea.de> Cc: freebsd-current@freebsd.org, kaktus@freebsd.org, sbruno@freebsd.org, Hans Petter Selasky <hps@selasky.org> Subject: Re: after update to r368166: no sound recording Message-ID: <D7E2EA58-01FF-4E9C-A909-261E5D73E09B@grem.de> In-Reply-To: <X9hpS7fAuuwm990i@c720-r368166.fritz.box> References: <X9hpS7fAuuwm990i@c720-r368166.fritz.box>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 15. Dec 2020, at 08:44, Matthias Apitz <guru@unixarea.de> wrote: >=20 > =EF=BB=BFEl d=C3=ADa lunes, diciembre 14, 2020 a las 10:16:21a. m. +0100, M= atthias Apitz escribi=C3=B3: >=20 >> I did a step by step down grading with 'svn up -r..... hdaa.c hdaa.h' >> (only these two files), starting from r368166 down to the following revis= ions: >>=20 >> r368166: no recording from pcm1 >>=20 >> r358333: no recording from pcm1 >>=20 >> r350078: no recording from pcm1 >>=20 >> r337043: recording is fine >>=20 >> I've cc'ed now the commiters of the r358333 and r350078. kaktus@ and sbru= no@ >> please check the issue https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D= 251727 >> and this mail thread in current@ >=20 > I have nailed down the problem and locally fixed it with this: >=20 > # svn diff sys/dev/sound/pci/hda/hdaa.c > Index: sys/dev/sound/pci/hda/hdaa.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/sound/pci/hda/hdaa.c (revisi=C3=B3n: 368166) > +++ sys/dev/sound/pci/hda/hdaa.c (copia de trabajo) > @@ -6598,6 +6598,7 @@ > devinfo->newgpo =3D -1; > callout_init(&devinfo->poll_jack, 1); > devinfo->poll_ival =3D hz; > + devinfo->init_clear =3D 1; /* added by guru@unixarea.de */ >=20 > hdaa_lock(devinfo); > res =3D hda_command(dev, >=20 > because there seems to be no code to set devinfo->init_clear from > loader.conf; there is in hdaa.c: >=20 > SYSCTL_ADD_INT(device_get_sysctl_ctx(dev), > SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, > "init_clear", CTLFLAG_RW, > &devinfo->init_clear, 1,"Clear initial pin widget configuration= "); >=20 > but I don't see any function like hdaa_init_clear_handler() which writes > the value to devinfo->init_clear;=20 >=20 > Am I mistaken? >=20 > matthias >=20 >=20 Good catch, I played with the sysctl as well as device.hints, both which did= n=E2=80=99t (seem to) make a difference. -m > --=20 > Matthias Apitz, =E2=9C=89 guru@unixarea.de, http://www.unixarea.de/ +49-17= 6-38902045 > Public GnuPG key: http://www.unixarea.de/key.pub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D7E2EA58-01FF-4E9C-A909-261E5D73E09B>