Date: Tue, 12 Dec 2006 15:09:03 -0500 From: John Baldwin <jhb@freebsd.org> To: John Polstra <jdp@polstra.com> Cc: freebsd-arch@freebsd.org Subject: Re: Where do MSI quirks belong? [patch] Message-ID: <200612121509.03785.jhb@freebsd.org> In-Reply-To: <XFMail.20061211152320.jdp@polstra.com> References: <XFMail.20061211152320.jdp@polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 11 December 2006 18:23, John Polstra wrote: > On 11-Dec-2006 John Baldwin wrote: > > Hmm. I did blacklist stuff several weeks ago but haven't had time to > > test it or post it yet. :( > > Oops. :-} Hardly your fault though. :) > > I do think I like your approach a bit better though. What I had so > > far is here: > > > > http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch > > > > I'm not sure if it's worth blacklisting MSI separate from MSI-X as that > > only makes a difference at the device level (chipsets just get a single > > memory write per interrupt either way, they can't tell MSI from MSI-X). > > Since the MSI support is really your turf, I'll happily defer to > you on it. If you decide my patch should go in, I could add the > additional blacklisted bridges from your patch, add the tunable > to ignore the blacklist, and eliminate the distinction between > blacklisting MSI and MSI-X. Let me know whether I should go ahead > and commit that. Well, I've tried to update my tree to be similar to your patch. One thing I did keep is that I want the blacklisting of PCI-PCI bridges to be something that happens while the request is bubbling up rather than just do a check on the immediate parent as in your patch. I want to make sure the entire heirarchy beneath a known busted bridge is blacklisted, not just the immediate children. I've gone ahead and committed some of the framework (such as giving the host drivers their own alloc methods) but I've changed the global blacklist to be MI as in your patch. Rather than creating a separate quirk table for MSI, I just added a new quirk type to the pci_quirks[] table and added the quirks there. Updated patch (relative to the stuff I just committed) is at the same location: http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch Can you review and possibly test it? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612121509.03785.jhb>