Date: Tue, 23 Dec 2008 19:05:54 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Doug Barton <dougb@FreeBSD.org> Cc: net@freebsd.org Subject: Re: ipv6 bugfix, need review. Message-ID: <20081224030554.GX18389@elvis.mu.org> In-Reply-To: <alpine.BSF.2.00.0812231145340.1179@ync.qbhto.arg> References: <20081223001216.GH18389@elvis.mu.org> <alpine.BSF.2.00.0812231145340.1179@ync.qbhto.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
* Doug Barton <dougb@FreeBSD.org> [081223 11:46] wrote: > On Mon, 22 Dec 2008, Alfred Perlstein wrote: > > >Hey guys, we found a bug at Juniper and it resolves an issue > >for us. I've been asked to forward this to FreeBSD, I honestly > >am not that clear on the issue so I'm hoping someone can step > >up to review this. > > > >Synopsis is: > > > > The traffic class byte is set to 0x00000000 in the header of some > > BGP packets sent between interfaces that have IPv6 addresses, > > instead of the correct setting 0xc0 (INTERNETCONTROL). > > > >Fix is small and attached. One thing I am wondering, do we > >need to check "if (inp)" ? I don't think so. > > How about adding an assert to the patch to prove this theory? :) > > I'll test it on my home box (which has IPv6) as soon as I'm done with the > stuff I'm working on atm. > > > hth, > > Doug Thanks Doug, will do. Please let me know results. do you know how to test if this is actually being excersized? I guess you could add a sysctl that gets incremented each time this codepath is hit to test? -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081224030554.GX18389>