Date: Tue, 21 Jan 2003 10:09:54 -0800 From: "Sam Leffler" <sam@errno.com> To: "Thomas Moestl" <tmm@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/sparc64/sparc64 iommu.c Message-ID: <04bf01c2c178$4cc3eca0$52557f42@errno.com> References: <200301211708.h0LH8Mn5005942@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> tmm 2003/01/21 09:08:22 PST > > Modified files: > sys/sparc64/sparc64 iommu.c > Log: > Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_* > constants where flag bits (as in NetBSD), although they are consecutively > numbered in FreeBSD. This would cause unnecessary flushing in the > BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless. > > Revision Changes Path > 1.16 +13 -5 src/sys/sparc64/sparc64/iommu.c > http://cvsweb.FreeBSD.org/src/sys/sparc64/sparc64/iommu.c.diff?r1=1.15&r2=1. 16 > Gack! Do you see a good reason for this? This seems like something that'll cause really hard to find bugs when porting drivers (though one should probably not use more than one flag per op). I'd really like to see these constants have the same value on all systems. Sam To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?04bf01c2c178$4cc3eca0$52557f42>