Date: Mon, 16 Nov 2015 10:31:11 -0700 From: Warner Losh <imp@bsdimp.com> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: CFT: uintmax_t rman Message-ID: <0F3B8FF2-E54E-446F-8D4E-415A1111EF4D@bsdimp.com> In-Reply-To: <75C2B97F-3C5E-49E3-A584-DE84463889FC@gmail.com> References: <75C2B97F-3C5E-49E3-A584-DE84463889FC@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_121AC1C5-0E33-4F7F-8C87-010CC726DBFB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 >=20 > On Nov 15, 2015, at 9:13 PM, Justin Hibbits <chmeeedalf@gmail.com> = wrote: >=20 > (Attempted to send this yesterday, but appears it didn't go through. = Apologies if it really did go through). >=20 > As part of a project getting FreeBSD on the Freescale P5020 SoC, I = increased the width of resources, from u_long(32 bits on 32-bit archs, = 64 bits on 64-bit archs) to uintmax_t (currently 64 bits on all archs). = I have it working on PowerPC, but have not tested it on any other = architecture, I have no other systems to test it with, so I need help. = This passes a tinderbox build. I need this tested on other archs, the = more the better, especially i386, including PAE. >=20 > It should be effectively a no-op on most architectures, especially = 64-bit archs, though there were some checks I found in x86 code clamping = address checks to under 4GB, commented as necessary purely for rman. If = this isn't the case, and we can't yet handle the checks being removed, = they can go in, but that needs testing. It should apply cleanly to = recent head. I like the idea. There=E2=80=99s nothing offensive enough in the diffs = to comment upon here (though I suppose I could see a few spots one could = quibble over if one were so inclined). I wonder, though, why not make its own typedef, even if it is just = =E2=80=98typedef man_res_t uintmax_t;=E2=80=99 in the rman headers? Warner --Apple-Mail=_121AC1C5-0E33-4F7F-8C87-010CC726DBFB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWShLgAAoJEGwc0Sh9sBEAB7YP/3Qo+bfyoRXhZ5cLVAghaZH9 Jbsn2VHRRhgMzq1UoIf65qV9f3tIBLKinYOnwBcYWTrCQ7pPib6a8chZrqE52r1g CZor5iSGD+zWpQnpDID7OF2SXbNV3RxlMzr4wJD5P161HDspgtyYHtDB7L7Mbrfh Wm/Hfq7DnEPFMItTD/JrRLyrpRpf9+Fm6EFx9F/RgdAHTglqannaKriTwBgOkpR8 fE2x29jZsFQxK63Qu36dofgpHkL10pS8L6pzjQjc+11nPa9mpdftBKwZjxlPjMbu CpX35gt2Udcwp0ohwfeinnZ3p6CPjCCGbT9V7ttRMpt7mgzC6AHCJQHq4xJhoWJF FfZp9JbZ3C9H04yUfjMFREKcy8Ufmz++sj91xTnNOtlfQKQFX3C57+3p1fS82YuL MYgUWgZULzOOU6BPzMVt1JVVhkN3sI/UuaXBm80/FIPK2cXEGiMc27RIg6bmlfD8 E5pJUj9lQzBmnUPug4hXAoUdZWt5718eC89hM1kUbhVvWYk2eM37Skhw7nU0uDxV PBS98QGrgUQgjszD9MAdbHo/5VMdVSVPd86Suo7Y3ZB93B0V2UCc6Hu6z8g74kQU KaaCwF9QvnUtaWqiDi6scvwV4ZcHBXrq3gLRl5t1Lqr5lN9n3gN9TusLIRXn0tUr gBk0qrNdpMv3mamiID16 =Fmq5 -----END PGP SIGNATURE----- --Apple-Mail=_121AC1C5-0E33-4F7F-8C87-010CC726DBFB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F3B8FF2-E54E-446F-8D4E-415A1111EF4D>