Date: Tue, 20 Jan 2004 12:48:39 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: HEADS UP: New bsd.*.mk changes Message-ID: <1074620919.757.51.camel@gyros> In-Reply-To: <400D68A1.4030501@fillmore-labs.com> References: <1074590694.85583.20.camel@shumai.marcuscom.com> <400D2939.5090203@fillmore-labs.com> <1074617147.757.16.camel@gyros> <20040120171315.GH94636@FreeBSD.org> <1074619795.757.43.camel@gyros> <400D68A1.4030501@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-zOnG7eDm4fzUo/+61Z85
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Tue, 2004-01-20 at 12:42, Oliver Eikemeier wrote:
> Joe Marcus Clarke wrote:
>=20
> > On Tue, 2004-01-20 at 12:13, Eivind Eklund wrote:
> >=20
> >>On Tue, Jan 20, 2004 at 11:45:47AM -0500, Joe Marcus Clarke wrote:
> >>
> >>>On Tue, 2004-01-20 at 08:12, Oliver Eikemeier wrote:
> >>
> >>[snipped description of options patches. -EE]
> >>
> >>>>Sorry for stepping up so late, but this saves options under
> >>>> ${PORT_DBDIR}/${PORTNAME}/options
> >>>>
> >>>>Lots of ports have the same PORTNAME (ie 'openldap' for
> >>>>net/openldap2[012]-(client|server), 'apache' for russian/apache13,
> >>>>www/apache(13|13-fp|2|21)). Some conflict, but -client/-server don't.
> >>>>Either each port has to set OPTIONSFILE to ${PORT_DBDIR}/${PORTNAME}/=
something,
> >>>>or we may use LATEST_LINK instead of PORTNAME:
> >>>
> >>>What's the general consensus on this (is there one)? What about ports
> >>>that set NO_LATEST_LINK? In any event, the patch below would need to =
be
> >>>tested on bento again (uggghh). Since OPTIONSFILE is currently
> >>>overrideable, couldn't porters that have conflicting PORTNAMEs, set th=
is
> >>>file to a unique name. For example:
> >>>
> >>>OPTIONSFILE=3D ${PORT_DBDIR}/${PORTNAME}/options.mozilla-devel
> >>>
> >>>Wouldn't that satisfy most people?
> >>>Perhaps we could shorten the public
> >>>OPTIONSFILE to just specify the filename, and do all the grunt work in
> >>>bsd.port.mk...?
> >>
> >>The following implements that, and is a fairly trivial patch.
> >>It might be even better to call "OPTIONSNAME" something like
> >>"UNIQUENAME".
> >=20
> > This looks okay to me, a gives the power to the porter to decide on a
> > truly unique name for options.
> >=20
> >>There is no obvious consensus - I have no particular opinion beyond
> >>what I've already said (ie, that the name of LATEST_LINK seems inapprop=
riate
> >>if it is to be used as a unique name.)
> >=20
> > I agree. This approach seems the most flexible. As for not being able
> > to do non-root installs, this is a bogus argument as one could simply
> > override PORT_DBDIR as they would PKG_DBDIR (even with the original
> > patch).
> >=20
> > Could you also change the comment documentation to reflect the new
> > macros? Unless there are serious objections to this, I'll commit this
> > approach.
> >=20
> > Joe
> >=20
> >=20
> >>Index: bsd.port.mk
> >>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
> >>retrieving revision 1.475
> >>diff -u -r1.475 bsd.port.mk
> >>--- bsd.port.mk 20 Jan 2004 09:14:09 -0000 1.475
> >>+++ bsd.port.mk 20 Jan 2004 17:07:33 -0000
> >>@@ -1017,7 +1034,8 @@
> >> # where 'make config' records user configuration options
> >> PORT_DBDIR?=3D /var/db/ports
> >>=20
> >>-OPTIONSFILE?=3D${PORT_DBDIR}/${PORTNAME}/options
> >>+OPTIONSNAME?=3D${PORTNAME}
> >>+OPTIONSFILE?=3D${PORT_DBDIR}/${OPTIONSNAME}/options
>=20
> Can we at least have
>=20
> OPTIONSNAME?=3D${PKGNAMEPREFIX}${PORTNAME}
>=20
> here? It makes sense for all the localized ports, perl, ruby, python, lin=
ux
> and others.
That makes sense...maybe having the whole trifecta is a good idea, too:
${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}
And what about UNIQUENAME instead of OPTIONSNAME? This way, it could be
used for other purposes.
Joe
--=20
Joe Marcus Clarke
FreeBSD GNOME Team :: marcus@FreeBSD.org
gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
--=-zOnG7eDm4fzUo/+61Z85
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBADWn3b2iPiv4Uz4cRAqjeAJ9mm9wxoIG3K6t0vXU1jk6dzauwQwCfbcdl
7FuxyakjMtozcHyudKAux9U=
=rsS/
-----END PGP SIGNATURE-----
--=-zOnG7eDm4fzUo/+61Z85--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1074620919.757.51.camel>