Date: Fri, 22 Oct 2004 16:47:03 -0700 From: Sean McNeil <sean@mcneil.com> To: amistry@am-productions.biz, ahze@ahze.net Cc: freebsd-ports@freebsd.org Subject: Bogus patch (was Re: avidemux2 fails to compile) Message-ID: <1098488823.37356.6.camel@server.mcneil.com> In-Reply-To: <1098487905.5676.3.camel@server.mcneil.com> References: <1098487905.5676.3.camel@server.mcneil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-4fJSDltJW1zSn5fXYLlZ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable There appears to be a bogus patch in the ports collection for audio/faac. Removing files/patch-gcc allows me to compile faac and avidemux2 without problems. The patch is removing a prototype of an exported routine and eliminates several pragmas. I do not know why the pragmas are removed as they were there for a reason plus any compiler that doesn't support them should just ignore it. I additionally do not know why the prototype for faacEncEncode is removed. It is required as the following information demonstrates: On Fri, 2004-10-22 at 16:31, Sean McNeil wrote: > With standard gnome2 and stuff installed under an amd64 I cannot compile > avidemux2. The problem is that faac is installed and it does not have > any prototype for faacEncEncode. >=20 > if c++ -DHAVE_CONFIG_H -I. -I. -I../.. -DXTHREADS -DXUSE_MTSAFE_API -I/u= sr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/gli= b-2.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include= -I/usr/X11R6/include -I/usr/X11R6/include/pango-1.0 -I/usr/local/include/f= reetype2 -I/usr/local/include -DTOOLAME=3D'"''"' -DEXLAME=3D'"''"' -I/us= r/local/include -I/usr/X11R6/include -I/usr/local/include/ffmpeg -I/usr/l= ocal/include/a52dec -I.. -IADM_library -I../ADM_library -D_LARGEFILE_SOUR= CE -D_FILE_OFFSET_BITS=3D64 -falign-loops=3D16 -MT audioeng_faac.o -MD -MP= -MF ".deps/audioeng_faac.Tpo" -c -o audioeng_faac.o audioeng_faac.cpp; \ > then mv -f ".deps/audioeng_faac.Tpo" ".deps/audioeng_faac.Po"; else rm -f= ".deps/audioeng_faac.Tpo"; exit 1; fi > audioeng_faac.cpp: In member function `virtual uint8_t AVDMProcessAudio_F= aac::getPacket(uint8_t*, uint32_t*, uint32_t*)': > audioeng_faac.cpp:166: error: `faacEncEncode' undeclared (first use this = function) > audioeng_faac.cpp:166: error: (Each undeclared identifier is reported onl= y once for each function it appears in.) > gmake[3]: *** [audioeng_faac.o] Error 1 > gmake[3]: Leaving directory `/usr/ports/multimedia/avidemux2/work/avidemu= x-2.0.32/avidemux/ADM_audiofilter' >=20 > Cheers, > Sean >=20 --=-4fJSDltJW1zSn5fXYLlZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBeZv3yQsGN30uGE4RAjPMAKCfCJLtbBpEVutXgGtfx+hDorSoFgCgoc11 6ErCeRmmbBoOtZpWV80M18g= =DKMF -----END PGP SIGNATURE----- --=-4fJSDltJW1zSn5fXYLlZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1098488823.37356.6.camel>