Date: Tue, 22 Feb 2005 14:23:42 +0100 From: Felix =?ISO-8859-1?Q?K=FChling?= <fxkuehl@gmx.de> To: Mikhail Teterin <mi@corbulon.video-collage.com> Cc: acardenas@bsdperu.org Subject: Re: ports/76257: nvidia_driver breaks xorg-clients build Message-ID: <1109078622.3320.2.camel@trabant> In-Reply-To: <200502220508.j1M58MAN094098@corbulon.video-collage.com> References: <200502220508.j1M58MAN094098@corbulon.video-collage.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am Dienstag, den 22.02.2005, 00:08 -0500 schrieb Mikhail Teterin: > > Could you try if the attached patch against xdriinfo.c works with > > NVidia's GLX? If it does, then I'll commit this to Xorg CVS. >=20 > Using glXGetProcAddressARB instead of glXGetProcAddress allows the > utility to build, but it still does not work -- the calls return NULL at > run-time. >=20 > If your program only works with Xorg's GLX, than, indeed, the error > message may need to become more informative. It was already changed in my patch. Do you have any better suggestions? >=20 > If, on the other hand, using the glXGetProcAddressARB works when linked > with Xorg's GLX -- why bother with the #ifdefs at all? Just use the old > call for the time being. :-) As I mentioned in an earlier mail, the GLX headers from Xorg don't seem to define the ARB function any more. >=20 > -mi >=20 > > --- ./xdriinfo.c.~1.1.3.1.~ 2004-06-16 11:27:39.000000000 +0200 > > +++ ./xdriinfo.c 2005-02-21 22:50:37.000000000 +0100 > > @@ -28,6 +28,14 @@ > > #include <unistd.h> > > #include <string.h> > > =20 > > +#ifdef GLX_VERSION_1_4 > > +# define GLX_GET_PROC_ADDRESS(name) \ > > + glXGetProcAddress((const GLubyte *)(name)) > > +#else > > +# define GLX_GET_PROC_ADDRESS(name) \ > > + glXGetProcAddressARB((const GLubyte *)(name)) > > +#endif > > + > > typedef const char * glXGetScreenDriver_t (Display *dpy, int scrNum); > > typedef const char * glXGetDriverConfig_t (const char *driverName); > > =20 > > @@ -57,10 +65,13 @@ >=20 --=20 | Felix K=FChling <fxkuehl@gmx.de> http://fxk.de.vu | | PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3 B152 151C 5CC1 D888 E595 |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1109078622.3320.2.camel>