Date: Fri, 27 Nov 2009 14:14:08 -0500
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: Kostik Belousov <kostikbel@gmail.com>
Cc: threads@FreeBSD.org
Subject: Re: [PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc
Message-ID: <1259349248.1608.36.camel@shumai.marcuscom.com>
In-Reply-To: <20091127131242.GA2368@deviant.kiev.zoral.com.ua>
References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-LTOyvPKDd72Gw9J7NAOr
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Fri, 2009-11-27 at 15:12 +0200, Kostik Belousov wrote:
> On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote:
> > I would like permission to commit this patch which adds missing
> > pthread_condattr_{init,destroy} symbols to libc. I think I did the
> > symbol addition correctly (and it seems to work). Without this, the
> > weak symbols added in the libpthread-stubs port conflict with those in
> > libthr, and applications with use these symbols can crash.
> >=20
> > I have temporarily hacked libpthread-stubs to fix this, but I really
> > feel these stubs should be added to libc. I've also copied kib as he
> > has been kind enough to review my work in the past. Thanks.
> >=20
> > http://www.marcuscom.com/downloads/stubs.diff
>=20
> It is FBSD_1.2 version that we use for symbols added after HEAD become
> CURRENT-9.
Done.
>=20
> I think that you shall change lib/libc/libc_private.h, adding
> corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT
> indexes.
>=20
> Is the patch buildable ?
Yes, but only because my machine had the libc_private.h chunk which I
forgot in the diff.
>=20
> Interesting question is whether these changes are mergeable to the
> stable branch. Possibly yes, if we declare that rtld/libc/libthr shall
> be built from the consistent source snapshot.
I would like to merge these changes to RELENG_8, RELENG_7, and RELENG_6
if possible. Anything which depends on dbus (e.g. GNOME) will just
crash without them. In the meantime, I have hacked libpthread-stubs,
but I really think this is the more correct fix.
http://www.marcuscom.com/downloads/stubs.diff
Thanks for the review.
Joe
--=20
Joe Marcus Clarke
FreeBSD GNOME Team :: gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
--=-LTOyvPKDd72Gw9J7NAOr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
iEYEABECAAYFAksQJQAACgkQb2iPiv4Uz4cDzACgksqz1AgY3wYLalYIEbnymzHQ
9+cAoIbhhO/4EAGQ7x1tc8MOLiKYyvS6
=cVKV
-----END PGP SIGNATURE-----
--=-LTOyvPKDd72Gw9J7NAOr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1259349248.1608.36.camel>