Date: Wed, 17 Jan 1996 17:27:17 -0800 From: John Polstra <jdp@polstra.com> To: freebsd-current@FreeBSD.org Subject: src/lib/libc/sys/Makefile.inc: proposed change Message-ID: <199601180127.RAA19205@austin.polstra.com>
next in thread | raw e-mail | index | archive | help
I ran into a problem in "src/lib/libc/sys/Makefile.inc" recently, and I want to see if anybody envisions any problems with a change I want to make to it. I was making a modified local version of the libc tree for generating an ELF library. That involved creating a couple of new preprocessor macros, and using them in some of the assembly language files. I don't have the precise details handy, but an assembly died on a statement something like this: movl $FOO,%eax where "FOO" was one of the new macros I defined. The problem was that, by default, "cpp" considers `$' to be a valid character in an identifier. So it was interpreting `$FOO' as an identifier, rather than as two separate tokens. This is never correct in i386 assembly language, since `$' is an operator that means "interpret as a literal". So I want to modify "Makefile.inc" in that directory so that cpp is invoked with the "-$" option, which makes `$' _not_ a valid identifier character. (Yes, I know I have to double the dollar sign in the makefile.) I tried it locally, and it seemed to work fine. Do any of you see any problem with making that change? -- John Polstra jdp@polstra.com John D. Polstra & Co., Inc. Seattle, Washington USA "Self-knowledge is always bad news." -- John Barth
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601180127.RAA19205>