Date: Fri, 2 Aug 1996 17:31:56 -0700 From: skynyrd@opus.cts.cwu.edu To: FreeBSD-gnats-submit@freebsd.org Subject: ports/1458: xf386 3.1.2E xterm prefers termios pico/pine over sgtty Message-ID: <199608030031.RAA07656@opus.cts.cwu.edu> Resent-Message-ID: <199608030040.RAA12996@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1458 >Category: ports >Synopsis: xf386 3.1.2E xterm prefers termios pico/pine over sgtty >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Aug 2 17:40:01 PDT 1996 >Last-Modified: >Originator: Chris Timmons >Organization: Central Washington University >Release: FreeBSD 2.1.5-RELEASE i386 >Environment: XFree86 Version 3.1.2E / X Window System (protocol Version 11, revision 0, vendor release 6100) Operating System: FreeBSD 2.0.5 Configured drivers: S3: accelerated server for S3 graphics adaptors (Patchlevel 0) mmio_928, s3_generic Using syscons driver with X support (version 2.0) (using VT number 4) pine-3.95 as prepared by our port >Description: The FreeBSD (bsf) port of pine through 3.95 has problems with the pico code when executed in an xf386 3.1.2E xterm. Pico (libpico, and therefore pine's message compose editor) catches an erroneous SIGHUP when the arrow keys are used to navigate around in the editor buffer, and the program terminates without explanation. >How-To-Repeat: Get the X11R6.1 libraries and suitable xterm binary, as one would with Xfree86 3.1.2E. Build pine 3.95 from our ports collection. Invoke pico, type several lines and try to get back to the top by using the up-arrow key. Pico bails out (because it catches a SIGHUP from somewhere.) >Fix: Early on I noticed that the NetBSD (neb) port did not suffer the same problem. I looked, and they -DPOSIX for the pico build which results in os_unix.c being compiled using termios rather than sgtty handeling. Adding -DPOSIX in pico/makefile.bsf corrects the problem, resulting in pico/pine binaries that run normally in both pre-X11R6 xterms as well as the one from 3.1.2E. diff -r1.1 makefile.bsf 34c34 < STDCFLAGS= -DBSDI -DBSDI2 -DJOB_CONTROL -DANSI -DMOUSE --- > STDCFLAGS= -DBSDI -DBSDI2 -DPOSIX -DJOB_CONTROL -DANSI -DMOUSE Although I believe this change to be otherwise innocuous I will leave it to the experts to decide if sgtty is a better way to deal with terminals that termios. ** also, minor nit not worth a seperate pr * While working on this I noticed that './build clean' from the work/pine-3.95 directory was not removing all of the .so files; this is because they call makefile.ult to clean rather than our nicely customized makefile.bsf :) 1,2c1,2 < *** build.orig Tue May 14 14:22:47 1996 < --- build Fri Jun 14 00:09:03 1996 --- > *** build.orig Tue May 14 12:22:47 1996 > --- build Fri Aug 2 17:01:06 1996 37a38,56 > *************** > *** 186,193 **** > echo "Cleaning Pine" > cd $PHOME/pine > ! make -f makefile.ult clean > echo "Cleaning pico" > cd $PHOME/pico > ! make $makeargs -f makefile.ult clean > echo "Done" > cd $PHOME > --- 196,203 ---- > echo "Cleaning Pine" > cd $PHOME/pine > ! make -f makefile.bsf clean > echo "Cleaning pico" > cd $PHOME/pico > ! make $makeargs -f makefile.bsf clean > echo "Done" > cd $PHOME >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199608030031.RAA07656>