Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Jul 1999 18:25:08 -0400
From:      Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To:        Doug <Doug@gorean.org>
Cc:        freebsd-ports@FreeBSD.org, nik@nothing-going-on.demon.co.uk
Subject:   Re: ports/12463: Update: Fvwm2 to 2.2.2
Message-ID:  <19990701182508.A31961@mad>
In-Reply-To: <Pine.BSF.4.05.9907011229590.13256-100000@dt054n86.san.rr.com>; from Doug on Thu, Jul 01, 1999 at 12:44:30PM -0700
References:  <19990701152359.C48778@mad> <Pine.BSF.4.05.9907011229590.13256-100000@dt054n86.san.rr.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 01, 1999 at 12:44:30PM -0700, Doug wrote:
> 
> 	I've done several ports myself, so I feel qualified to judge it in
> context. In particular, the COMMENT is most important (IMO) in the

If anything, that would disqualify you, but if we used that criteria,
we'd disqualify far too many people.  :)

> sysinstall case, where they are viewed one at a time. I submit that you
> are looking at them en masse, which a typical user would never do. 

Disagree, strongly.  Even in sysinstall, they are viewed en masse.  

Then there's also the README.html files, again, en masse.


> don't believe that legislating the use of articles at the beginning of the
> sentence adds utility in comparison to the pita factor of trying to
> enforce it. 

The PITA factor of enforcing the lack thereof is pretty low.  :)


> >    [585]unclutter-8
> >           Remove idle cursor image from screen
> >    [1396]wget-1.5.3
> >           Retrieve files from the 'net via HTTP and FTP
> 
> 	Should be, "Retrieves . . ."
[etc]

Well, either way.  They should be consistent.  I'm happy with
"Retrieves", etc., although that means one less character is
available.


> 	My main point is that having the A/An there DOES improve the
> readability, at a very low cost. I don't see a compelling reason to change
> them one way (all A's) or the other (no A's). We have more than enough

I was interested in opinions on this.  I can't say how thoroughly I
disagree.  I hope someday you will change your mind.  I will wait
patiently until then.  I hope others jump in and give me an excuse to
remove the "A "s, though.  I still have trouble believing that there
is much of a chance you are right.


> reason not to allow a little creativity/variety in an area that has no
> signficant impact one way or the other. 

Uh, I wouldn't exactly call this a creativity issue....


> > I'm also considering that maybe I should've made an exception and not
> > capitalized "perl5" when it appears at the start of a comment.
> 
> 	My understanding from the Perl FAQ is that the proper punctuation
> should be, "Perl 5". 

Same, but the de facto standard was "perl5 module" until I changed a
bunch of them to "Perl5 module", which I wouldn't have done if I'd
reviewed the diffs more closely.

Incidentally, in this case I value de facto standard pretty highly.


-- 
This is my .signature which gets appended to the end of my messages.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990701182508.A31961>