Date: Tue, 20 Jul 1999 09:18:41 -0600 From: Nate Williams <nate@mt.sri.com> To: hosokawa@itc.keio.ac.jp (HOSOKAWA Tatsumi) Cc: mobile@FreeBSD.ORG Subject: Re: usr.sbin/pccard/pccardd change for "cardio" and "cardmem" Message-ID: <199907201518.JAA19388@mt.sri.com> In-Reply-To: <199907201331.WAA22907@afs.ntc.mita.keio.ac.jp> References: <199907201331.WAA22907@afs.ntc.mita.keio.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
> Following patch (derived from PAO3) adds two keywords ("cardio" and
> "cardmem") to pccard.conf. "cardio" and "cardmem" specifies I/O
> address and memory address regardles of CIS tupple (so-called "builtin
> point enabler"). These keywords are needed for broken CIS cards and
> hardwired driver code, etc.
Can you be more specific? When are these used? It has been my
experience that too often 'broken cards' are in fact not broken, and the
FreeBSD code is broken. Adding workarounds for (potentially) broken
code is not a good fix.
However, I don't want to discount the possibility of broken cards, or
that FreeBSD's current code in incapable of supporting certain cards
without these additions. I'd like to know what kind of cards/situations
these types of keywords are used for.
> This patch is needed by flash ATA support (Mr. Losh is working on
> kernel side of flash ATA support).
>
> If there's no objection, I'll commit it soon.
>
> --
> HOSOKAWA, Tatsumi
> Assistant Manager
> Information Technology Center, Keio University
> <hosokawa@itc.keio.ac.jp>
>
>
> Index: cardd.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/pccard/pccardd/cardd.c,v
> retrieving revision 1.34
> diff -u -r1.34 cardd.c
> --- cardd.c 1999/02/05 16:00:17 1.34
> +++ cardd.c 1999/07/20 13:14:38
> @@ -179,6 +179,9 @@
> sp->config = 0;
> /* release io */
> bit_nset(io_avail, sp->io.addr, sp->io.addr + sp->io.size - 1);
> + /* release irq */
> + if (sp->irq)
> + pool_irq[sp->irq] = 1;
> }
Yikes, this patch should be done no matter what. Are irq's ever freed
in the old code?
Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907201518.JAA19388>