Date: Tue, 20 Jul 1999 18:52:45 -0600 From: Warner Losh <imp@village.org> To: Nate Williams <nate@mt.sri.com> Cc: hosokawa@itc.keio.ac.jp (HOSOKAWA Tatsumi), mobile@FreeBSD.ORG Subject: Re: usr.sbin/pccard/pccardd change for "cardio" and "cardmem" Message-ID: <199907210052.SAA89724@harmony.village.org> In-Reply-To: Your message of "Tue, 20 Jul 1999 18:39:05 MDT." <199907210039.SAA23797@mt.sri.com> References: <199907210039.SAA23797@mt.sri.com> <199907201852.MAA20790@mt.sri.com> <199907210014.JAA27543@afs.ntc.mita.keio.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199907210039.SAA23797@mt.sri.com> Nate Williams writes: : Again, what is it that this patch fixes? What bug and/or feature does : this add to FreeBSD? It's really hard to have an opinion on the : 'goodness or badness' of a piece of code when there's no description of : what the patch does? He's already done that nate in the code that you clipped. What the patch gains us is the ability to work with more pccard and compact flash cards than we'd get without it. It also help us kludge around wd.c's too intemate knowledge of where the ide controller lives. Mr. Hosokawa-san has already stated this explicitly in the mail message that you replied to. How much clearer does he need to be? The patch may not be 100% pure. However, if it works, then it is better than what we have now (which is nothing). Also, longer term there will be no pccardd, so the usual concern about long term maintainability is not present here. If we need to deviate from architectural purity to gain functionality, I'm all for it in this case. Short term there is nothing but upside (eg ata flash card support). Long term there is no downside because the code will be dead in a few months. Given these realities, I don't think it is worth arguing over... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907210052.SAA89724>