Date: Wed, 30 Aug 2000 10:24:21 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: committers@FreeBSD.org, net@FreeBSD.org, Garrett Wollman <wollman@FreeBSD.org>, Bill Fenner <fenner@FreeBSD.org>, Darren Reed <darrenr@FreeBSD.org>, Kannan Varadhan <kannanv@malgudi.research.bell-labs.com>, Frank Volf <volf@oasis.IAEhv.nl> Subject: Re: [Call for review] ICMP error generation fixes Message-ID: <200008301724.KAA30942@bubba.whistle.com> In-Reply-To: <20000830150327.C69333@sunbay.com> "from Ruslan Ermilov at Aug 30, 2000 03:03:27 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov writes: > http://people.FreeBSD.org/~ru/icmp-fixes.2 > > 5. Following the suggestion from Darren Reed, ip_output() now expects all > three fields, ip_len, ip_off and ip_id(!) in host byte order. It was You need to add a NTOHS(ip->ip_id) to div_output() as well. Did you grep for all occurrences of calls to ip_output()? There may be others as well. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008301724.KAA30942>