Date: Sat, 13 Jan 2001 09:52:45 +1030 From: Greg Lehey <grog@lemis.com> To: Samuel Tardieu <sam@inf.enst.fr> Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/24271: dumpon should check its argument more Message-ID: <20010113095245.A66238@wantadilla.lemis.com> In-Reply-To: <200101121610.f0CGA7a52473@freefall.freebsd.org>; from sam@inf.enst.fr on Fri, Jan 12, 2001 at 08:10:07AM -0800 References: <200101121610.f0CGA7a52473@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, 12 January 2001 at 8:10:07 -0800, Samuel Tardieu wrote: > On Fri, 12 Jan 2001 16:48:57 +0100, Samuel Tardieu <sam@inf.enst.fr> wrote: > On 12/01, Bruce Evans wrote: >> On Fri, 12 Jan 2001 sam@inf.enst.fr wrote: >> >>>> Description: >>> dumpon should check that the argument is not a disk slice, or should >>> require a flag (-f?) in this case. It would prevent bad crashes :/ >> >> This is a feature. dumpon (like swapon and newfs) should work on any disk >> device, including the whole disk. It currently only works on disk devices >> whose containing slice is labeled, so it can only be misused to clobber >> BSD slices and not OtherOS slices (this is a bug :-). > > I would recommend to add a "-f" option anyway. It is way too easy to set > (as I did yesterday) "dumpdev=/dev/ad0s2" in your rc.conf and be very > surprised after a crash. If you really want to do this, you could do it > with a "dumpon_flags=-f". Agreed. There may be reasons to accept that you want to use an entire slice for your dump device, though I can't think of a convincing one, but it certainly shouldn't be the default. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010113095245.A66238>