Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Apr 2001 07:51:35 -0500
From:      Mike Pritchard <mpp@mppsystems.com>
To:        Brian Somers <brian@Awfulhak.org>
Cc:        Greg Lehey <grog@lemis.com>, Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/vinum vinum.8
Message-ID:  <20010428075135.B55634@mppsystems.com>
In-Reply-To: <200104280315.f3S3Fk504631@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Sat, Apr 28, 2001 at 04:15:46AM %2B0100
References:  <grog@lemis.com> <200104280315.f3S3Fk504631@hak.lan.Awfulhak.org>

next in thread | previous in thread | raw e-mail | index | archive | help
OK, how about a cooling off period?  

As someone who has done a *LOT* of mdoc work, let me review the changes?
You will have to give me 4 days or so due to my work schedule (sounds
like a good cooling off period to me :-), and I will review what was done.  
And either have a counter-patch, or my comments.

OK?

-Mike

On Sat, Apr 28, 2001 at 04:15:46AM +0100, Brian Somers wrote:
> > On Friday, 27 April 2001 at 22:36:05 +0100, Brian Somers wrote:
> > >> On Friday, 27 April 2001 at  3:32:49 -0700, Ruslan Ermilov wrote:
> > >>> ru          2001/04/27 03:32:49 PDT
> > >>>
> > >>>   Modified files:
> > >>>     sbin/vinum           vinum.8
> > >>>   Log:
> > >>>   mdoc(7) police: fix markup.
> > >>
> > >> Review rejected by: grog
> > >
> > > What's the problem with the change ? 
> > 
> > See my review message.  Initially, the issue was that it hadn't been
> > reviewed.  The review showed a large number of problems.
> 
> I haven't seen any review, so I can't comment.
> 
> > > The only thing that looks arguable is that they aren't backwards
> > > compatible (more than 8 args stuff).... but such is the price of
> > > progress.
> > 
> > You sound like a Microsoft salesman: "Well, yes, it doesn't quite run
> > your old games like the old one, but look at the snazzy GUI".
> 
> ??  More like ``here's a new game (vinum.8), it doesn't run on old 
> machines (groffs)''.
> 
> > In fact, I suspect that you're referring to a macro incompatibility
> > here, and that it will go away.
> 
> I'm referring to the inability to nroff the -current man page - you 
> need the latest groff.
> 
> > Greg
> > --
> > Finger grog@lemis.com for PGP public key
> > See complete headers for address and phone numbers
> 
> -- 
> Brian <brian@Awfulhak.org>                        <brian@[uk.]FreeBSD.org>
>       <http://www.Awfulhak.org>;                   <brian@[uk.]OpenBSD.org>
> Don't _EVER_ lose your sense of humour !
> 

-- 
Mike Pritchard
mpp@FreeBSD.org or mpp@mppsystems.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010428075135.B55634>