Date: Tue, 17 Jul 2001 15:28:05 -0700 From: Jordan Hubbard <jkh@freebsd.org> To: obrien@freebsd.org Cc: drosih@rpi.edu, bde@zeta.org.au, jhb@freebsd.org, dd@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org, wollman@khavrinen.lcs.mit.edu Subject: Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us Message-ID: <20010717152805Y.jkh@freebsd.org> In-Reply-To: <20010717102707.C74750@dragon.nuxi.com> References: <Pine.BSF.4.21.0107171745520.65013-100000@besplex.bde.org> <p05101005b77a19ecc632@[128.113.24.47]> <20010717102707.C74750@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
From: "David O'Brien" <obrien@FreeBSD.org> Subject: Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us Date: Tue, 17 Jul 2001 10:27:07 -0700 > On Tue, Jul 17, 2001 at 12:50:39PM -0400, Garance A Drosihn wrote: > > Yes, I see the bit about "merged changes from vendor branch", > > but I suspect that would not wave any red flag at me if I > > were just looking to modify this source. > > The vendor tag of "ADO: 1.1.1" should also clue you in. Actually, since I've been looking at our published guidelines rather carefully as of late, I think that John has a very valid point and Garrett does not. From the committer's guide: Don't commit to anything under the: src/contrib src/crypto and src/sys/contrib trees without explicit approval from the respective maintainer(s). The trees mentioned above are for contributed software usually imported onto a vendor branch. Committing something there, even if it doesn't take the file off the vendor branch, may cause unnecessary headaches for those responsible for maintaining that particular piece of software. Thus, unless you have explicit approval from the maintainer (or you are the maintainer), do not commit there! It doesn't say that only "big" code goes here nor is it documented ANYWHERE that one should look around for special tags before committing. In fact, the inference is very strong that those explicit locations are reserved for this kind of thing and the rest of the tree is not assumed to be vendor branched. We have a lot of new committers coming into FreeBSD with more being added every day. If we can't document our own processes or claim that people should just somehow magically be familiar with "established precedent" then we're doing them a real disservice and making our own claims of being an organized development process somewhat hypocritical at best. The case of "zic" is a clear case of "personal preference over policy" and not something really open to debate, not that that's ever stopped us from debating things before.. A little consistency would be nice here folks - it's frankly bizarre to see a discussion about how much the rules matter and another about how they don't going on at the same time. - Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010717152805Y.jkh>