Date: Wed, 5 Sep 2001 20:39:34 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/include/arpa tftp.h Message-ID: <20010905203608.K22645-100000@alphplex.bde.org> In-Reply-To: <20010904185643.A78975@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Sep 2001, David O'Brien wrote:
> On Tue, Sep 04, 2001 at 09:38:36PM -0400, Garrett Wollman wrote:
> > <<On Tue, 4 Sep 2001 18:31:13 -0700 (PDT), "David E. O'Brien" <obrien@FreeBSD.org> said:
> >
> > > include/arpa tftp.h
> > > Log:
> > > style(9) the structure definitions.
> >
> > Was this *really* necessary?
> >
> > I thought we had a policy against doing broad sweeps of
> > non-substantive changes like this.
>
> Yes it was -- we were so confused (partically do to your commit to
> style.9) that one could not figure out what was right. Now enough of the
> key places to look for style guidlines have been fixed. I don't plan on
> sweaping any more of the tree to just fix this.
The existence of both in old code means that they were both right.
"struct\t.*{" does seem to be the least normal form although it is used
in the oldest code (proc.h...), but you shouldn't have changed it while
we are still discussing this.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905203608.K22645-100000>