Date: Fri, 14 Sep 2001 10:29:51 +0100 From: Brian Somers <brian@freebsd-services.com> To: Josef Karthauser <joe@tao.org.uk> Cc: Garance A Drosihn <drosih@rpi.edu>, Brian Somers <brian@freebsd-services.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: Proposed patch to log_accum.pl Message-ID: <200109140929.f8E9Tpd26809@hak.lan.Awfulhak.org> In-Reply-To: Message from Josef Karthauser <joe@tao.org.uk> of "Fri, 14 Sep 2001 04:01:46 BST." <20010914040146.A32158@tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Sep 13, 2001 at 10:32:00PM -0400, Garance A Drosihn wrote:
> >=20
> > For parsing purposes, I was thinking of something more like:
> >=20
> > Revision Changes Path
> > 1.108 +6 -5 src/sys/kern/kern_descrip.c
> > 1.1 +123 0 src/sys/kern/new_file.c (new)
> > 1.234 0 -669 src/sys/kern/dead_file.c (attic)
> >=20
> > I'd want the same number of columns under "Changes" for those people
> > who parse this by splitting on blanks.
>
> That's a fair point, and the reason I put two columns in in the patch.
>
> How about:
>
> Revision Changes Path
> 1.108 +6 -5 src/sys/kern/kern_descrip.c
> 1.1 +123 X src/sys/kern/new_file.c (new)
> 1.234 X -669 src/sys/kern/dead_file.c (attic)
>
> or some other character to pad the column out, but to indicate that
> there's no value there?
Hmm, I think the X looks odd.
If we have (new) and (attic) then we don't need the Xs. If we have
the Xs (or even if we have nothing) we don't need the (new) or
(attic).
Personally I prefer my original suggestion on the basis that it has
no duplicated information. Parsing is easy, but not as easy as
having a pad character.
When all's said and done, a script can parse it whatever the format,
so I think you should just decide what you think is best Joe :*)
> Joe
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109140929.f8E9Tpd26809>