Date: Sun, 25 Nov 2001 14:45:40 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Ian Dowse <iedowse@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/tail forward.c Message-ID: <20011125144540.A93369@xor.obsecurity.org> In-Reply-To: <200111251803.fAPI3SG79146@freefall.freebsd.org>; from iedowse@FreeBSD.org on Sun, Nov 25, 2001 at 10:03:28AM -0800 References: <200111251803.fAPI3SG79146@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 25, 2001 at 10:03:28AM -0800, Ian Dowse wrote: > iedowse 2001/11/25 10:03:28 PST >=20 > Modified files: > usr.bin/tail forward.c=20 > Log: > Since kqueue support was added to tail, the "-F" option (check for > renames/rotations) only detected cases where the file itself was > moved or deleted. If part of the path to the file (or a symlink > in the path) was changed instead, tail would not notice. > =20 > Fix this by ensuring that we stat the path at least once every > second in the -F case to check for changes. We still use kqueue > when possible to inform us quickly when the file has changed. Hmm, this strikes me as a bit nasty...ideally you shouldn't have to poll for any status changes in a kqueue world. Is there an easy way kq could be improved to handle this? Kris --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8AXRVWry0BWjoQKURArISAKCNdeBWRHbDggZFgD2PUm311fau4gCg2lAO EVeoUyuwcNIgMnqs1+bVt/w= =cBpN -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011125144540.A93369>