Date: Thu, 10 Jan 2002 19:12:09 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20020110191209.A318@dhcp01.pn.xcllnt.net> In-Reply-To: <xzpy9j5hecf.fsf@flood.ping.uio.no> References: <200201100536.g0A5aao01807@freefall.freebsd.org> <xzpy9j5hecf.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 11, 2002 at 02:21:36AM +0100, Dag-Erling Smorgrav wrote: > Marcel Moolenaar <marcel@FreeBSD.org> writes: > > marcel 2002/01/09 21:36:36 PST > > > > Modified files: > > sys/compat/linux linux_ioctl.c > > Log: > > Further fixes related to the interface renaming. Now that we > > properly translate the interface name passed to us, make sure > > we also translate correctly before we return the list of > > interfaces with the SIOCGIFCONF ioctl. It is common to use > > the interface names returned by that ioctl in further ioctls, > > such as SIOCGIFFLAGS. > > > > Remove linux_ifname as it is no longer used. Also remove > > ifname_bsd_to_linux as it cannot be used anymore now that > > linux_ifname is removed (was deadcode anyway). > > Please back this commit out. It is incorrect, and I (the author of > the code that it modified) was not consulted. It is correct WRT the translations done the opposite direction. If this is incorrect, the other fixes are also incorrect. Either they both go, or they all stay. Since you didn't object to the first round of fixes, I don't see how you can object to this one. I also fail to see how you can object now while it should have been you who should fix the problems created by the code you wrote, and not me. Thirdly, you did not consult me when you made the changes, as I was at that time the official *active* maintainer of the Linuxulator. So, all considered, I urge you to be constructive and provide good explanations as to why you think it is broken and I'm sure we can sort it all out. In the mean time the only conclusive evidence I have is that it fixes a bug. I have yet to see a report that it breaks something else. Hence, so far there's not a single indication that the change is wrong and as such I don't see a need to revert the change. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020110191209.A318>