Date: Fri, 11 Jan 2002 12:25:34 -0800 From: Alfred Perlstein <bright@mu.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Marcel Moolenaar <marcel@xcllnt.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20020111122534.K7984@elvis.mu.org> In-Reply-To: <xzpd70ghc78.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Jan 11, 2002 at 09:20:11PM %2B0100 References: <200201100536.g0A5aao01807@freefall.freebsd.org> <xzpy9j5hecf.fsf@flood.ping.uio.no> <20020110191209.A318@dhcp01.pn.xcllnt.net> <xzpu1tth859.fsf@flood.ping.uio.no> <20020110203918.A440@dhcp01.pn.xcllnt.net> <xzppu4hgkwg.fsf@flood.ping.uio.no> <20020111112851.A2103@kayak.xcllnt.net> <xzpd70ghc78.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smorgrav <des@ofug.org> [020111 12:20] wrote: > Marcel Moolenaar <marcel@xcllnt.net> writes: > > > > Wrong. Linprocfs doesn't need fixing. Please back out your incorrect, > > > poorly though-out and poorly tested commits, or I will. > > It looks like you backed out reason already. Clearly there's no point > > in talking it over first. Whatever you want, Des... > > Since when does "talking it over first" mean "commit a patch without > discussing it with the person who wrote the code it changes"? > Especially when similar patches have been suggested, discussed, and > rejected before (see for instance the audit trail for PR 26546). You don't give a reason for your: "Partial fix committed, more work remains to be done." This should have included _why_ you didn't incorperate the diffs instead of just stating that you didn't. It would make both the PR originator as well as fellow developers understand why and how you are doing things. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020111122534.K7984>